From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57C82A0093; Tue, 19 May 2020 16:51:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24E8F1D633; Tue, 19 May 2020 16:51:01 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 37FCF1D15D for ; Tue, 19 May 2020 16:50:59 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8EF2E5C0181; Tue, 19 May 2020 10:50:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 19 May 2020 10:50:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= WT8efIP0ndE9ur6quvch3/z3zT1tmTC2irokLXFM+ds=; b=Z96gNPS8gOlqvwaD UXJGNnCg3niTJI1BzAckXvw3YQgMGABZknU3e0i8TV9AA4hZhYcXZyZZsALuTQg2 acLOCLhXSU3cW0Wyr9nbAW/ERkxnpOgQKn6cgaI1g2hSwFBsONxsiGL26Kvoipfm GD3Ek07J8iXOFAOzfwTnVIBbN7nMagQw+Zmusv9lFnyEx/SE7xLdZAP4OR7fF8S0 lgP3HlK+bR6UZq8yHQzXOqwq3BpnnEUG7oCM2WsJPrDFQ2oqvjLGtQL6wzBsGnhr ny1J6diNGudIcJ0fFyzDqwpGhyVxJeRE4sdQVfFIG1yYbGvq1FuE17Ct1f0TVC21 wBhJWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=WT8efIP0ndE9ur6quvch3/z3zT1tmTC2irokLXFM+ ds=; b=YDOwoTRRR4OEBl8YP7qh00KB01p4qDm+PpIONnHDcKQGkq+ADLHvGTSLQ uS9L6/p0XUh88X3eiq3K21lTquSe9BlJkh3/0/0hWfq5lJlO8VUN/0dT0V/3FbU2 XMwJr2oej+a8CHs5TxEzyqA42/kTyrXGimZE0oXxYpr/rd9M9IY5rH3EePfFzzUS kDX3TULqAzIY4smISvWEQiNpS0FPsA1nZwBHlpRtsTHNVM5XQDUOYLKPoWy7Htkc mgY1s9ca2iJuPU9twnsh1+AUW1xZnHVMqIlw5HYg9WI85zU+wsIqxBDZR1yvJYAF /HWtOSowLFVxoo+HdE+tacLnKwsEQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtjedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AC40F328005A; Tue, 19 May 2020 10:50:57 -0400 (EDT) From: Thomas Monjalon To: Darek Stojaczyk Cc: dev@dpdk.org, Bruce Richardson Date: Tue, 19 May 2020 16:50:56 +0200 Message-ID: <2315401.7eYt6pKtYU@thomas> In-Reply-To: <20200507101350.123873-1-dariusz.stojaczyk@intel.com> References: <20200326092259.33957-1-dariusz.stojaczyk@intel.com> <20200507101350.123873-1-dariusz.stojaczyk@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] build: don't parse build configs of explicitly disabled drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/05/2020 12:13, Darek Stojaczyk: > Even when a PMD was disabled with meson's disable_drivers option > its config file was still being parsed. Some of the PMD configs > attempt to find a library they depend on and parse its header files > with certain assumptions. If the library is found, but it's simply > too old to contain the necessary header files, the meson build > fails and it can only be fixed by either updating that library, or > expanding the meson script for the faulty PMD. > > While the latter should be still done for the sake of DPDK quality, > an intermediate solution would be to skip building the faulty PMD > - there's a chance we don't need it. That's what this patch allows. > > Signed-off-by: Darek Stojaczyk > Acked-by: Bruce Richardson > --- > v2: > - simplified the code with if X.contains(), as Bruce suggested > - removed the related comment from the code - it should be > self-documented now Applied, thanks