From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44F4BA0C46; Fri, 23 Jul 2021 11:18:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C4A64014D; Fri, 23 Jul 2021 11:18:12 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 58A824003C for ; Fri, 23 Jul 2021 11:18:10 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B401C5C016C; Fri, 23 Jul 2021 05:18:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 23 Jul 2021 05:18:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= AgAP2u2qWtuw+JxOaxytgpmUwhpDb7jNYVmKuTECkb8=; b=gz0qQ2WDPHjONFQO Dm3jtkNdVs0844jsIb9w73K8EE2hVW5BPeAu/GixL31nHaLFtOVVLUDVvt6HYCnk pOsELPpH5hkk46FprHBXBFm/aZvPG8FuOWzD9SbWrzqFqvGFqMF8617VtXb+ER34 U0RiQiqNA1o95peTrcbTAo52zMzbKgUeGpA0zRlni+eNtU317QhJeZ4Gbx/zclZh OwDhZIos/kYmDN0g1pBlaDBcLLMAtlPmZ+ch+hKiPWLKmWmdZRS07Qk+a8OBOc3J fm/7ddqcd3b/rPhLQKzj+0LwyPLAS0aK5mm99ENS5BJVOPPeynkF9Hd8vPuZSzzF U52TGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=AgAP2u2qWtuw+JxOaxytgpmUwhpDb7jNYVmKuTECk b8=; b=iVedhuXq0OADusw7pnHMYolmaXG0zVvea31BDR4SBfyiLMTpjgXg41nhK q7NH5D3OsQ2V2kJh/+KqrTUVJvXRmtMzfKZTVqwhsLdKF+5P5S6qsGjsvb2Sbiow OYkGLc3rNmc213Uju2z0JBUentcTSwhSmJUStle8PmSfKcF1Dp7mxTCQTjbJAkFb dFDmzo8Rqmi4RyRBc6zb6/Oe5CZsmhpxhlviFNgaOcWctRqo36TryUM/ZmQpwEAM +T/jQSlB/8K6T5so9G2+GCKEcmr6mYzv1+CxBKNcRdL0ldtvyigXk8cvmW7NEwgv d7S4ABGY1vDzYhnR/7ttskf0jFnJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeekgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jul 2021 05:18:08 -0400 (EDT) From: Thomas Monjalon To: Heinrich Kuhn , Simon Horman Cc: dev@dpdk.org, david.marchand@redhat.com Date: Fri, 23 Jul 2021 11:18:29 +0200 Message-ID: <2316407.RpMWIsvfqF@thomas> In-Reply-To: <20210716083545.34444-1-heinrich.kuhn@netronome.com> References: <20210716082314.33865-1-heinrich.kuhn@netronome.com> <20210716083545.34444-1-heinrich.kuhn@netronome.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/7] Refactor the NFP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/07/2021 10:35, Heinrich Kuhn: > This patch set restructures the NFP PMD, aligning it more with the > common layout adopted by most other PMD's. Although the changes look > fairly large, functionally nothing is added or removed from the driver > and the existing code is mostly just reorganized into the familiar > structure seen in other PMD's. It seems this refactoring is destroying this firmware improvement: https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781 Please rebase carefully, keeping the behaviour really intact. > Apart form adopting the common PMD layout > this change should also aid in future feature development to the NFP > PMD. The previous layout where most of the logic resided in a single > file (nfp_net.c) would have become tedious to support going forward.