From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D666CA0A02; Wed, 24 Mar 2021 11:36:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66B024067B; Wed, 24 Mar 2021 11:36:08 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 502404014F for ; Wed, 24 Mar 2021 11:36:07 +0100 (CET) IronPort-SDR: 810x8JWbOnIf+gpRlxTMx/dPHI/jQUZipZAIf7mumKwqCH/32Ub3F9pnw5nhi2LOOn77eTRTA3 qsh9Dt4iV0Ug== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="252034342" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="252034342" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 03:36:06 -0700 IronPort-SDR: /4sT9eJsA0sU+dlToF5FRJMho/Z5r0YdJ81w4HljX1CJaH8kLjMPzI1uTfkzYuzDfvoxrICkxV 8FwXu7HPz+tw== X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="408782163" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.28.141]) ([10.252.28.141]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 03:36:05 -0700 To: Jiawen Wu , dev@dpdk.org References: <20210316105149.110904-1-jiawenwu@trustnetic.com> <67bae872-de2b-07ce-2655-7e7b7ba07118@intel.com> <00cc01d72051$0ebe47b0$2c3ad710$@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <231d1fe4-b76a-3506-415a-0372ec290c7b@intel.com> Date: Wed, 24 Mar 2021 10:36:01 +0000 MIME-Version: 1.0 In-Reply-To: <00cc01d72051$0ebe47b0$2c3ad710$@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 0/7] txgbe backplane AN training X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/2021 1:57 AM, Jiawen Wu wrote: > On March 24, 2021 1:33 AM, Ferruh Yigit wrote: >> On 3/16/2021 10:51 AM, Jiawen Wu wrote: >>> This series update link process for backplane NICs. >>> And support to control AN training. >>> >>> v2: >>> - Convert compile time flags to runtime options >>> - Move firmware version get operation to base code >>> - Fix minor bugs >>> >>> Jiawen Wu (7): >>> net/txgbe: update device ID >>> net/txgbe: add device arguments >>> net/txgbe: move firmware version get function to base code >>> net/txgbe: update link setup process of backplane NICs >>> net/txgbe/base: support to handle backplane AN73 flow >>> net/txgbe: handle AN interrupt and link update >>> net/txgbe: add FFE parameters for user debugging >>> >> >> Hi Jiawen, >> >> Overall set looks good, just to double check, is there anything to update in the >> release notes, can briefly mention from new device args perhaps? > > Yeah, it should be. > I'd like to update the release notes in an individual patch, would it be appropriate? > It is preferred to have the doc update with the actual functional change patch, I see you have sent the doc as separate patch, I can squash it while merging.