From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id 649559ABC for ; Tue, 24 Feb 2015 21:09:33 +0100 (CET) Received: by wesw62 with SMTP id w62so27455733wes.9 for ; Tue, 24 Feb 2015 12:09:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=OTwHYrriXs5uPQZIONNxuW5si12/bPHNU/vdyHXzxgY=; b=mTUjh1t6CKS1n0gUitfWtmy/puP+lfnJq+p9fu9nwKhmXshp/Onkt4y00RScRxnLK+ G2vN4HksdTbnYMmt9UfK+pmEhePk/7S8369yCMgK45ZapxkT7QNjDjKDAZw5yznbERSq GbcjkwNllcgKpLdQqcSTkgzT9JCfCDnaH0rjXKGS5UIkvcLe3PWcfyWyQ14qNu/v5YMG AxYI6aPvwUVvKvJiJJ6UmzigxdweDX4vPDa5ITYfoY7tgHJeHTHJSg/8RyQLzYiZzkRI 73dtMwIBMqiLIkp8jZLyKeILB9CTPVClXRpIbB2dSU0KtY6quTLbBNMlBQqlDzb9IyW4 SAZQ== X-Gm-Message-State: ALoCoQkUppT+intTnHTKR96rr9WhAq1CfFqaPc3Zwwr4lUXoqPTE8Q7NZdfn8DVHnMZWU8yJq2ZO X-Received: by 10.180.86.227 with SMTP id s3mr33609790wiz.58.1424808572313; Tue, 24 Feb 2015 12:09:32 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u6sm21978020wix.12.2015.02.24.12.09.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 12:09:31 -0800 (PST) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Date: Tue, 24 Feb 2015 21:08:59 +0100 Message-ID: <2321165.OmIMUBx4lj@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1424348324-29932-1-git-send-email-pawelx.wodkowski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 20:09:33 -0000 2015-02-24 19:16, De Lara Guarch, Pablo: > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > > Pablo > > Sent: Tuesday, February 24, 2015 7:11 PM > > To: Wodkowski, PawelX; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd- > > jobstats example > > > > > > > > > -----Original Message----- > > > From: Wodkowski, PawelX > > > Sent: Tuesday, February 24, 2015 4:33 PM > > > To: dev@dpdk.org; De Lara Guarch, Pablo > > > Subject: [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example > > > > > > This app demonstrate usage of new rte_jobstats library. > > > It is basically the orginal l2fwd with following modifications to met > > > library requirements: > > > - main_loop() was split into two jobs: forward job and flush job. Logic > > > for those jobs is almost the same as in original application. > > > - stats is moved to rte_alarm callback to not introduce overhead of > > > printing. > > > - stats are expanded to show rte_jobstats statistics. > > > - added new parameter '-l' to automatic thousands separator. > > > > > > Comparing original l2fwd and l2fwd-jobstats apps will show approach what > > > is needed to properly write own application with rte_jobstats > > > measurements. > > > > > > New available statistics: > > > - Total and % of fwd and flush execution time > > > - management time - overhead of rte_timer + overhead of rte_jobstats > > > library > > > - Idle time and % of time spent waiting for fwd or flush to be ready to > > > execute. > > > - per job execution time and period. > > > > > > Signed-off-by: Pawel Wodkowski > > > --- > > > examples/Makefile | 1 + > > > examples/l2fwd-jobstats/Makefile | 51 ++ > > > examples/l2fwd-jobstats/main.c | 1040 > > > ++++++++++++++++++++++++++++++++++++++ > > > mk/rte.app.mk | 4 + > > > 4 files changed, 1096 insertions(+) > > > create mode 100644 examples/l2fwd-jobstats/Makefile > > > create mode 100644 examples/l2fwd-jobstats/main.c > > > > > > diff --git a/examples/Makefile b/examples/Makefile > > > index 81f1d2f..e847ded 100644 > > > --- a/examples/Makefile > > > +++ b/examples/Makefile > > > @@ -50,6 +50,7 @@ DIRS-$(CONFIG_RTE_MBUF_REFCNT) += > > > ip_fragmentation > > > DIRS-$(CONFIG_RTE_MBUF_REFCNT) += ipv4_multicast > > > DIRS-$(CONFIG_RTE_LIBRTE_KNI) += kni > > > DIRS-y += l2fwd > > > +DIRS-y += l2fwd-jobstats > > > DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) += l2fwd-ivshmem > > > DIRS-y += l3fwd > > > DIRS-$(CONFIG_RTE_LIBRTE_ACL) += l3fwd-acl > > > diff --git a/examples/l2fwd-jobstats/Makefile b/examples/l2fwd- > > > jobstats/Makefile > > > new file mode 100644 > > > index 0000000..d57a0ae > > > --- /dev/null > > > +++ b/examples/l2fwd-jobstats/Makefile > > > @@ -0,0 +1,51 @@ > > > +# BSD LICENSE > > > +# > > > +# Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > > > > Fix these dates. Plus, there was a conflict due to a recent commit, > > modifying examples/Makefile, so make sure you rebase ;) > > Well, actually, I am in doubt. This is a modified version of an existing app. > In that case, copyright dates should contain the dates of that app, or just > the year where it was created this modified app? I think you should keep the dates of the original file. It would be interesting to have lawyer's opinion. If there is no other problem, I'm going to apply this patchset.