From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2E85423B8; Thu, 12 Jan 2023 16:00:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C2DE40E25; Thu, 12 Jan 2023 16:00:13 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 705A240DDC for ; Thu, 12 Jan 2023 16:00:12 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 570023200959; Thu, 12 Jan 2023 10:00:09 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 12 Jan 2023 10:00:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1673535608; x= 1673622008; bh=akmSSrPEpU+dHupN3qHNwqIpuZSYG4mvGx01EzWpT2Y=; b=u XbUCJaELPZ3y/M6aO/Oo3UE7cL+OxNdQFhd0ywK9lYUvsMQmweVRWPao8RkJ9I6x aGAd41WsZBw90JMXHiuAtOKzCEFZ/pIw7ndftgcDPI5vBFcrqZHQ8Ds0MQbSZq9H R35nnJP0cZkEXmg4U0mNC2b3FiiomV2Kco28f611qQHdvUHHvAwNprzm+2l/VTcc HD+pnunNoc1tFkXxiEraUDvrRQFDqYscHSHQn/uA3zhANBzFd7H+h++sWuJRneg0 b7kSay56fblYq5MhY3ADfIL+16RkVGdgchYD0+BXstKzunA8MWHKwXdO2GnnaEwR rttzXIOs+c8YLupxq7FkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673535608; x= 1673622008; bh=akmSSrPEpU+dHupN3qHNwqIpuZSYG4mvGx01EzWpT2Y=; b=I cs56S4v3et2qQI6jbtEhzf1gXbuPb/C+4CKdsHc7m4M4sSINTiEQH2eiVGaf8AKc lti13FYOeOVYfPAnt52pisvALTB8jP30ZidcPRYHwSUNlDZ90yOFj8JgO6//HN7V LYgaxM9/KZUwxxb0LcvfTF+LYdRvBJ/0jkgpGyWFuzDaGUPD7+jZ7pjjL7GkSAi3 0mfE9Tqd8Lzp3A2sP61w59+WCT7fR3qlnkj5/3JIO68g0T5BYVhzmR9BALElyoPR VQWG9pelAmPGTJTOzKIvA4YIIFDSHFoKRF/hMbQ00b5zxLRjZ0gGkiB1BHgDLEXw LAyjxI0cxCl+3MRgaFQTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleeigdejtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Jan 2023 10:00:06 -0500 (EST) From: Thomas Monjalon To: Akhil Goyal , "Ji, Kai" , "De Lara Guarch, Pablo" Cc: "dev@dpdk.org" , Tyler Retzlaff , "dev@dpdk.org" , David Marchand , "Dooley, Brian" , "Power, Ciara" , "Mcnamara, John" Subject: Re: [PATCH] crypto/qat: fix build Date: Thu, 12 Jan 2023 16:00:05 +0100 Message-ID: <23216321.6Emhk5qWAg@thomas> In-Reply-To: References: <20221230210728.86920-1-thomas@monjalon.net> <3685739.QJadu78ljV@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/01/2023 14:22, De Lara Guarch, Pablo: > Hi Thomas, > > From: Thomas Monjalon > > 12/01/2023 11:32, Ji, Kai: > > > Ok, a long story short, this issue should only occurred when > > RTE_QAT_LIBIPSECMB is enabled. > > > It was intend to remove Openssl lib dependency in QAT replaced with > > > ipsec_mb lib, but the work was partially done due to limitation of > > > ipsec_mb by the time (FIPS certification) > > > > > > I'm happy with current fix and please cc: stable@dpdk.org > > > > I'm not happy with this fix. It is a dirty workaround. > > It would be better to have an #ifdef in ipsec_mb. > > > > Also I would like an answer to the question below. What triggered this error? > > Is it a new thing in the lib ipsec_mb? > > Why defining AES_BLOCK_SIZE while IMB_AES_BLOCK_SIZE can be used and > > have a proper prefix? > > Apologies for the late response. > > This macro was renamed to IMB_AES_BLOCK_SIZE, as you already know. > The problem is that, for compatibility reasons, we had to keep the old macro as well. > However, we added a compile time flag to remove these legacy macros, for exactly this reason > (NO_COMPAT_IMB_API_053). > > I think a solution could be to use this flag in QAT, so the legacy macros are not defined. > > I will send a patch to fix this. OK good, so we can reject this patch?