From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 60F43431FC;
Wed, 25 Oct 2023 18:46:37 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 33D2D40EF0;
Wed, 25 Oct 2023 18:46:37 +0200 (CEST)
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com
[64.147.123.21])
by mails.dpdk.org (Postfix) with ESMTP id F3FD740042;
Wed, 25 Oct 2023 18:46:35 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.west.internal (Postfix) with ESMTP id F016B3200914;
Wed, 25 Oct 2023 12:46:33 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Wed, 25 Oct 2023 12:46:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm3; t=
1698252393; x=1698338793; bh=esRKAnw1et6+NjeubpyApd0mze5HCVBUtMh
1fQDoMfk=; b=qNCk+V4cKhnB6X4pWmdfOWtbDtBJHAV8Qm/nTmlwh6rzdI0aa8j
aC8ME1tYZAXwTF6v3022/5kJNFDsOsfGnorJ/h0A80r8qj3vLpdftqQRmXGDLtLo
cTMNJJU2mjXA/gw193VBjTb+teNXbmlHTcymzgsiiiZPXf5VTqLYF32+1nplBSFY
+/UjM+/NIa4KmyJJhHKIf5WTONmFzKkpiPJSdhzk+ICxmr6zsLyXKYsNLYgyyc00
snwnt+lDbfIuC77gigYQNZ8lVECdclY86lbKjXZavdIBSbe3317CyNJol6h2k6Ws
UFDy3idUxIXkB+UIxm7r1yHyjN91Xx4vJIg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
1698252393; x=1698338793; bh=esRKAnw1et6+NjeubpyApd0mze5HCVBUtMh
1fQDoMfk=; b=poK8qnBHLU5wdb+GbMQms01eV9MI5EA98rshka8VPvFS2eAyLRK
DjwkDi02s+FGYB6/xAWcEAHag0t+mctZN1itB4F+dLD6LkKqPSzIgTDaRLQfGwni
z7/QSYIBPxFwYeG/kH9JLQmO/asyz6+C1l8Yf487uD33A297h4eAc4ukYpoFodup
Ma6KN9WnLGgvFKoiOf8nABxmifHddkvyYyjLe04kU+v6bvEDoa02pXGITuIosQ4V
g2zcTnMiJvigiuszuxdkiq7jBzEPhd6oMDkjKWdd3f63QTe/9JPY7R6GHIJhc+P2
vaTC9GbgJpKJ1y6Lm42TYzH+HVNYBeQdO4g==
X-ME-Sender: <xms:aEY5ZY9rWWEeeU9hU1atLM3JlQ9Mhn3TTuPwwLS4fePEYMka4cCvow>
<xme:aEY5ZQtifzu7G14eUL64urygaR1twnsiACKoNsXQAP9Xf_coUY1Mzl0c4qZL-TCQ-
shEJAIwDAsn2ZCqcw>
X-ME-Received: <xmr:aEY5ZeD41qp_4-knAm5vJ_VhL7O-sDxMPYS_wFP77_38GwT94bAQ58EFp91p5sdzfS4Qr6vfM6NahUzUwoUcb53JgQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledtgddutdegucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei
kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:aEY5ZYejhNSLXK0UidAGHMB9v40oFUargCdCf9Y3TI14NbTv-TgB7w>
<xmx:aEY5ZdOuHLYR-9TDVydS5qWK2bXc6HGAS27GG_V_pXVaviOJORjy1w>
<xmx:aEY5ZSmesvQyfVP7AWRRAAhyjH14OWitEaUV-BEpl6mJzpLb7tYhcA>
<xmx:aUY5ZSmNwM-32QIKB3P9BKSYp6_2qA7nSXQcn0idQZHVkyQz2cQOfg>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
25 Oct 2023 12:46:31 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>, stable@dpdk.org,
Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH v2] eal/unix: allow creating thread with real-time priority
Date: Wed, 25 Oct 2023 18:46:29 +0200
Message-ID: <23265462.6Emhk5qWAg@thomas>
In-Reply-To: <20231025083700.4e3e274c@hermes.local>
References: <20231024125416.798897-1-thomas@monjalon.net>
<20231025151352.995318-1-thomas@monjalon.net>
<20231025083700.4e3e274c@hermes.local>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
25/10/2023 17:37, Stephen Hemminger:
> On Wed, 25 Oct 2023 17:13:14 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > case RTE_THREAD_PRIORITY_REALTIME_CRITICAL:
> > + /*
> > + * WARNING: Real-time busy loop takes priority on kernel threads,
> > + * making the system unstable.
> > + * There is also a known issue when using rte_ring.
> > + */
>
> I was thinking something like:
>
> static bool warned;
> if (!warned) {
> RTE_LOG(NOTICE, EAL, "Real time priority is unstable when thread is polling without sleep\n");
> warned = true;
> }
I'm not sure about bothering users.
They can fear something is wrong even if the developer took care of it.
I think doc warnings for developers are more appropriate.
I've added notes in the API.