DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] management of non-PCI devices
Date: Thu, 23 Jul 2015 17:42:58 +0200	[thread overview]
Message-ID: <2330484.OMtusG3QG9@xps13> (raw)

As noticed when reviewing the changes for hotplugging ring PMD,
	http://dpdk.org/ml/archives/dev/2015-July/021872.html
a driver is considered in ethdev and EAL as a PCI driver:

 * Each Ethernet driver acts as a PCI driver and is represented by a generic
 * *eth_driver* structure that holds:
 * - An *rte_pci_driver* structure (which must be the first field).
 * - The *eth_dev_init* function invoked for each matching PCI device.
 * - The *eth_dev_uninit* function invoked for each matching PCI device.
 * - The size of the private data to allocate for each matching device.
 */
struct eth_driver {                                                                                              
    struct rte_pci_driver pci_drv;    /**< The PMD is also a PCI driver. */
    eth_dev_init_t eth_dev_init;      /**< Device init function. */
    eth_dev_uninit_t eth_dev_uninit;  /**< Device uninit function. */
    unsigned int dev_private_size;    /**< Size of device private data. */
};

So the non PCI drivers don't use rte_eth_driver_register().
Then a difference is made with these flags:
enum pmd_type {
    PMD_VDEV = 0,
    PMD_PDEV = 1,
};

With this kind of weird things:
static struct rte_driver rte_virtio_driver = {
    .type = PMD_PDEV,                                                                                            
    .init = rte_virtio_pmd_init,
};
Because virtio is a virtual device with a virtual PCI address.

All these things are not normal and make EAL code more and more difficult to
maintain. That's why we must stop accepting new code using these workarounds
and start working on a refactoring.

Comments welcome

             reply	other threads:[~2015-07-23 15:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 15:42 Thomas Monjalon [this message]
2015-07-23 16:33 ` Iremonger, Bernard
2015-07-23 16:51 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2330484.OMtusG3QG9@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).