From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 3204B532C for ; Wed, 13 Mar 2019 12:13:56 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 37C3F388B; Wed, 13 Mar 2019 07:13:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 13 Mar 2019 07:13:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Xq/X9xPh2/sC2DsYTieZrQnG00Anh2MzXvEWpkRRX68=; b=D9qD2ZCK2LUp 4/H2Fj3ZFjcKw4sFAV5pX7+ybBaqPJNC8Dh/gLeDNqxwqEb241AU2ZnQM0y2DN0I D/hDWpN7z07tbEgeOdYklbWbwUCa10ugz/8bY1KL8KnfUvb9/rbxTXNvQc3X8gCq P+J78whWSBsI2nEV4qgXAYjywZiaCco= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Xq/X9xPh2/sC2DsYTieZrQnG00Anh2MzXvEWpkRRX 68=; b=AenbWmtU6tUqAYfZXoewXFOtsVmJdy5K9bj7vWH9LiVaREDF5xeAj+p4p lmZau8AvH4HI/tlMDtH9pw942IQFKVPA6YnH+j25xfFAF6NEkUnKuXa9xF0uBuNz ynNqL4F32tXBzD5oNtK268785Py8sZcU7Ml4Ahp3r78TGO40OL1aYxudL3ByRikC caAic/F9DquMXkfOAqLcBof6ZaBC/K2Z8MqOvAyPFzYVuj4GV9vF8UGvOVAKys/A iZDz61abd1g5wf+mmC0Xvhixs/vT7e9I74YDKxE6o61rCq+teaJo+QZzRQhTtkcU LoGxMrIjSW2SGt/09hp3TtqEWZ8aw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrhedtgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9760410336; Wed, 13 Mar 2019 07:13:53 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, David Marchand , Luca Boccassi Date: Wed, 13 Mar 2019 12:13:52 +0100 Message-ID: <2333456.BDb5ShVbCQ@xps> In-Reply-To: <20190307133502.55321-3-bruce.richardson@intel.com> References: <20190307115448.54041-1-bruce.richardson@intel.com> <20190307133502.55321-1-bruce.richardson@intel.com> <20190307133502.55321-3-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/4] build: use version number from config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 11:13:56 -0000 07/03/2019 14:35, Bruce Richardson: > +# > +# Version information completed when this file is processed for a build > +# > +CONFIG_RTE_VER_YEAR=__YEAR > +CONFIG_RTE_VER_MONTH=__MONTH > +CONFIG_RTE_VER_MINOR=__MINOR > +CONFIG_RTE_VER_SUFFIX=__SUFFIX > +CONFIG_RTE_VER_RELEASE=__RELEASE [...] > -/** > - * Patch release number > - * 0-15 = release candidates > - * 16 = release > - */ > -#define RTE_VER_RELEASE 0 So you are removing the special value 16. Is it replaced by an empty value? I think it is an issue for version comparison with RTE_VERSION_NUM() macro. The -rc3 must be lower than the final release (which had number 16 for this reason).