From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id D52AD8E65 for ; Fri, 13 May 2016 12:12:27 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id a17so21861552wme.0 for ; Fri, 13 May 2016 03:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=pVuF0i9sj1CelaDIaeKzzFBLbCoUJufBfeIPBd0eJUY=; b=LnDS/vGiuBpJT6/us2PO7VGU7EYvnoCO+/Xr9ywqOeFPhOJkBBtB5LevLl99Ui9Qcv i4Jkq38LEGth3+ZYFuoUHLK+BNVkpc0sSzGmQttoaZq+wnTmiR0SOJNsHWB2toHTeuvA amrPG28jNdZklzf7K5At5mjq888+IhWfii8JZsmAJoJdcvlwGEidVp4jdcnwqZmCer8G 1XZILbC9H6OfpyoSk6NNSaRyUtT2EypF0YHOyASiZwyOX/I004pqPX4KiQVFglqSkt6G qxIYvlS7hrajlSaY9YSn8bW+trLs4kSssNm0UzvsPxMlZF8bg5CAXwS+93Jwom/Jesqx zxvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=pVuF0i9sj1CelaDIaeKzzFBLbCoUJufBfeIPBd0eJUY=; b=J5fiRc0D5rrYiOMU3xnGIJ6ijliP7Q4UHc0UU6DENVpf4UjFPLSm958ynLonxoJqFf Ra3Exg/oep/LsRpjYt7gpfJxRFwRQ+PttWSZYHzN4WRS5xLkcznQPOA8ecgrAvw6Qe0V FJaYNZ4EHVoALZhnzJyabb6wysNFKBb1nsLfYhr4+nuxY+oz8FoSQCll2Tmk1aAf4YSu uuEGmtvacQcxUrUUpZ8U2rizFOHBom9/dqUZnIK/qKSIX0AZeQUgRPIwXx7mO+4zJJG0 9uccrmdxoiwk0EC87wYloS67H+hzg94kGoiCrdNceiEp7zoQGYyTFH8KG7mY2T/WfVsy 6YPQ== X-Gm-Message-State: AOPr4FVf2Abg8CZbjXIzDaDmMnsGQBRscW/R/JL73ujGbPYtp6Ib4r9M1F8UBB0HbWB9KlDa X-Received: by 10.194.134.170 with SMTP id pl10mr14338099wjb.88.1463134347725; Fri, 13 May 2016 03:12:27 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id gk4sm17753534wjd.7.2016.05.13.03.12.26 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 May 2016 03:12:26 -0700 (PDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" Cc: dev@dpdk.org, Ferruh Yigit , "Mrzyglod, DanielX T" Date: Fri, 13 May 2016 12:12:25 +0200 Message-ID: <2334631.A0rgQzR3nq@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <5732FF68.50801@intel.com> References: <1462875064-119474-1-git-send-email-danielx.t.mrzyglod@intel.com> <3EB4FA525960D640B5BDFFD6A3D89126479BAF1D@IRSMSX108.ger.corp.intel.com> <5732FF68.50801@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] sched: fix useless call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 10:12:28 -0000 2016-05-11 10:46, Ferruh Yigit: > On 5/10/2016 6:18 PM, Dumitrescu, Cristian wrote: > > As previously discussed on this email list, the rte_bitmap_free() is an API function that works as a placeholder for any resource freeing that needs to be done for the bitmap. The API function should not be removed and also the call to this function from the rte_sched_port_free() should not be removed either. > > > > Right now it isn't required and doesn't do anything. > Why not add this function when it is required? I don't understand why we keep a function which does nothing.