From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0B17A04DD; Wed, 18 Nov 2020 15:42:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFD4AC902; Wed, 18 Nov 2020 15:42:44 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id B5107C8FA for ; Wed, 18 Nov 2020 15:42:41 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 111925800FE; Wed, 18 Nov 2020 09:42:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 18 Nov 2020 09:42:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= RFxzuYri2S7+L1NNXu5T/bWC/Ovh65EcX/I2mg5NGrU=; b=GTlvjmGeozcvrOlI XDEPxNj3aaN9YWSvToQoJIinXnTSBiudHvP4d/Mzemc9/F0/L8KdttdRkXGTkpJj wULvIetK1RMKdiq33zrR5hy3owFhHgBb291sJuapONvP/LAnBNhMdcR0jqDGCRE1 3fglhORkV0pIFpvC2AqY6qK/vh5ghDuw2Lr2iwklWhSwZomikWSjbBuieeMYZt/Q 27+zlG8q3rZi4QeI/upuKjeqH/KrnqcIac+BX+xc2dVUegR6RJf5YbGWH54D9jjN dA/CUe6+txp32m9X7jlENIrjhxlqJQEDAski62nSUKrDWn3vhabo+Z2WFSuXqgVQ f4Trlg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=RFxzuYri2S7+L1NNXu5T/bWC/Ovh65EcX/I2mg5NG rU=; b=FS5PAuL6FcRM78QEi1t/8YgCd7H5qA6rFVks9zUk1yjeCYNR6tEauaVLM 5MuOZWRLRjTHJ0suuIBIY6dxva8YTM+n9YXhTVtIUdK2yXSSy7UTTKOJH5k3tiqg glc4a6MCfntbo6yaQwk2Cu3JQ6tPT9VdsSm1kcFj2f+kVp66ee6uYxcAHCqrwaF6 HPjt9hUDhGLjU4zGgOZhliatIiMymotu34TjQGbXfZ5Ms1MekJG34YKeg0/L6XOx tvVI+/voB9dBe9G3CfZAK2ysIh78glHxgMFNoz+0hK0xFiZMMVShUDRviDkSz02M bWrIilyd34fb9jrPf+U7tZjKWYFtQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefhedgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepueehueeuvdfggefftdeilefgtdfggfejfeehveekieegvdduieei uddtuedufeeunecuffhomhgrihhnpeguvghtvggtthhiohhnrdhsohenucfkphepjeejrd dufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 201213064AA7; Wed, 18 Nov 2020 09:42:38 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: "Ruifeng.Wang@arm.com" , "Honnappa.Nagarahalli@arm.com" , "Phil.Yang@arm.com" , "vcchunga@amazon.com" , "Dharmik.Thakkar@arm.com" , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "ajit.khaparde@broadcom.com" , "ferruh.yigit@intel.com" , "dev@dpdk.org" Date: Wed, 18 Nov 2020 15:42:36 +0100 Message-ID: <2337679.hKZaPKL2be@thomas> In-Reply-To: References: <1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech> <11763925.GOiJPSdkav@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/11/2020 15:19, Juraj Linke=C5=A1: > From: Thomas Monjalon > > 16/11/2020 10:13, Bruce Richardson: > > > On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas Monjalon wrote: > > > > 13/11/2020 15:31, Juraj Linke=C5=A1: > > > > > +option('max_lcores', type: 'integer', value: 0, > > > > > + description: 'maximum number of cores/threads supported by EAL. > > > > > +Set to positive integer to overwrite per-arch or cross-compilati= on > > defaults. Set to -1 to detect the number of cores on the build machine.= ') > > option('max_numa_nodes', type: 'integer', value: 0, > > > > > + description: 'maximum number of NUMA nodes supported by EAL. Set > > > > > +to positive integer to overwrite per-arch or cross-compilation > > > > > +defaults. Set to -1 to detect the number of numa nodes on the > > > > > +build machine.') > > > > > > > > First comment: I don't like having so long description. > > > > Second: I don't understand. > > > > > > > > It is said the default value is 0 so I expect it means automatic de= tection. > > > > But later it is said -1 is for detection. So ? > > > > > > > Zero is for the "per-arch or cross-compilation default". This was > > > discussed quite a bit in previous versions and this was te best > > > compromise we could come up with. Having a default of auto-detect is > > > definitely not something I think we should go with - just thinking of > > > all the build CI jobs running on > > > 2 or 4 core VMs! However, Juraj really felt there was value in having > > > auto-detection, so it's set as a -1 value, which I'm ok with. > >=20 > > The problem is that I don't understand what 0 means. > >=20 >=20 > There are three pieces of information which we need to convey: > 1. The default value (0) indicates that per-arch or cross-compilation def= aults will be used. > 2. Positive integer values will be used instead of these defaults. Where these positive values come from? > 3. Detected values will be used for native build when the value is -1. Why not detect for any native build set up with 0 (default)?