From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04455A0560; Tue, 18 Oct 2022 19:03:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4A7A410F2; Tue, 18 Oct 2022 19:03:04 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2083.outbound.protection.outlook.com [40.107.92.83]) by mails.dpdk.org (Postfix) with ESMTP id 0E4F140395 for ; Tue, 18 Oct 2022 19:03:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ck1cArQ9oDU4ut1amJBxHX5+KuH+iGKLVJT9ChuY7+wKNPmKJh+mQy2JGQRUoQB9ad0xtAd1EBog1AhAqgi7QyRe/Gs9LO3sZzyYzUSPXeoWty4HNus6TGWTqFHIdookVWGunY1A2JZraut1ppeYw/hl19OziuZLBShORz6IJNY31Wm2HJycelLoQPm5HcrmruIzVN5ApHSwgPWuBNOsjxqzTYSvHJXS+xbyytsIgepuTiWeCmYtvG1iQV485lw8dMCNUNaR4Fx8Q1/ZWMg7V6yk0WI7MQmf0Vw/tSzjQRh+vWe6VBn/ybOFbmj/WhJlBsbczB1Ugy13I+vmsEfIIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=je64uES9hYHpEByDj88gzDfGaRWWWxPP4fYF4amoSnI=; b=SJFlhqmZij8+25AbICt7Bdkx/lJAyF/wkAwitafPA4DiY5GMHL7ouhGsraB4RqJXRZew0fOZxO3+ifHmlXTcJ0KIPi7gkLw5ZJc4154gmbRQh+pImZZsrXQQ8r8Xo/jDu4a8+1+nMmQcn5hZ2hdzb/Yv6aCA2Vjjs764JfmI/1ZBme3a97EGNQX6HyrZIPNQaLwzBFY5mqsdQPwYtVzLTSFB1/+Em2MGD4KmG/xRCHhmmVwGaAFovMp8MsKZYN3acwrVtkQTlZG7O5bi4sMMwfTwLWNUbuXSjH8/b9pYjurcYFO9U3c9zKjs06J+BGGMwiPJcCVGni29J2e1rTPYog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=je64uES9hYHpEByDj88gzDfGaRWWWxPP4fYF4amoSnI=; b=G1akpP4Rh26pilhHe7XgpGpbSdDpR6arcsafP1u+1a5zbMZXTzWCXKmT38Vd4VoJJaEff+KL6r1kR6XzMUl0NNZbywmE3dKN8q8maoRatGlBr9nprD71cvImjgzz+VXgMZg138O7jFdhwzgJclSfSkhc+IYxWJu2Kbc6Yer+wcM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DM4PR12MB5328.namprd12.prod.outlook.com (2603:10b6:5:39f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct 2022 17:03:01 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 17:03:01 +0000 Message-ID: <2339eb13-3872-f041-6fd6-3a247034a491@amd.com> Date: Tue, 18 Oct 2022 18:02:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 06/35] net/ionic: update documentation and copyrights Content-Language: en-US To: Andrew Boyer , dev@dpdk.org References: <20221007174336.54354-1-andrew.boyer@amd.com> <20221007174336.54354-7-andrew.boyer@amd.com> From: Ferruh Yigit In-Reply-To: <20221007174336.54354-7-andrew.boyer@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0369.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::14) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|DM4PR12MB5328:EE_ X-MS-Office365-Filtering-Correlation-Id: c9dd0242-fe79-42ef-3441-08dab12a9d2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0wtqCMLsBIVzhsVC/aTDerFiySuNNjMGXEeYdDSilJpVRAajGsWrk3+k674P+BO6VICVUjVQb3JrbBv1Ig/mEbsTGi8Cu62a5Nji+kMrEvFzlI4wu5tBdOYM0M2po5Bh5VzW5RIx2xSiEMnTt9YwOx59deajuM2kf0mP4EL+4AQNcpYqGRk9AALo+hwb0MSaQ65d2rCKAlrN4wKO6dqtxwbH33jVMeyyryPDhe6EAoj2Uf4zMeRIsLlGSSJbyl/EheL871ewySFLe9T2NqIugsInvFi1MYPok4UtgjoNlsLFVwTXqqHMqcq3w+abZbwo4ZH3AVTHgZeiuReIh56WeZAbnKM2akjj4Opn6Vxw3wBqRqfM20cvcu2d1gDh4gzV9MgaNJeQExFIm1k/dIhWnualhoZg9htkqOuLRVUbxU/8Rd2q1AKaZRdier3Q2R5qkixyQEJaOTD/JwLM2mBxHfBeSmjtc6TSRvsgJilBCJktcufqghNFJRx2ES4AP2QWg0qKzYQTwUoYSVKSKkBfp2oamxgrPD2CdHFdBpmyv8ASHa4dgS7Gpl9iZPGRO4k1mDdDGvwT5IB5kZ4WFG0kngilsPGAHLUhMVs8ytea/eaEeOG2mSjJxUVH86nn2zopzUXbyqx691nCJngLtTDbajpeWF/Z5uaGsUkuSXTPKkxxPME9sykvgqUi19f2hRXafw/AGichfRHOM2IA3tAdN+tQyNGMeSAqGfejxiaeqkeb4Dvvub12zvaFdc0N6AmaIzjLfv8AaaKGpwelLRx6H4E4F5AVRCcnvN/a1qytXb/slMT4kWXqyW4PeuneSDmHFbauiQrOkq1M0SdCxYobkbb7v5qWw8QLvpQN+MXm3X2z8BvvmAS1uswK58fW50uc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(451199015)(86362001)(31696002)(36756003)(31686004)(38100700002)(2906002)(44832011)(186003)(15650500001)(5660300002)(53546011)(6512007)(2616005)(478600001)(83380400001)(6666004)(26005)(6506007)(6486002)(966005)(316002)(66946007)(66556008)(66476007)(41300700001)(8676002)(8936002)(15398625002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmpDVEROMFZVWGp4eGt0V0dOWXAyb0lsS2FtSkpwdFZUbFQyZzhETHkxMGEx?= =?utf-8?B?Ums0UTRQRVM1VnpKRk1wRHZnS2hPRkRWcXRBTUVMbTNjUkJ2ZnRhRkszd1Iv?= =?utf-8?B?dzVEN1pFRVVxL1VBSkkyT3JOSDVudklGMExKdGtueE5Cd3FSa0RsZmI1L1Mz?= =?utf-8?B?Y0dSYldneS9FWk9UeEpxejQzTXNobCthVnMzRjFzcjN5QUh2anJmV2ZybEM2?= =?utf-8?B?TXpNUFF6SU44V1g0L1JKSUlSUGdJSjZhMm5xZVg3VCtWUmJ5dFA4VUNRQURI?= =?utf-8?B?N1Z3YkNEUStNWHNPRHhRUDM3RnBGcXozYVRLN0QyNVY3cVE0M2RmeExxVVRZ?= =?utf-8?B?U09hTnlubUdLOXZzbDZaRnVHekdyR0k3NjRBd3NQQ0F5c0p3YmljT0VqYlg4?= =?utf-8?B?ckJhM29nUlA0MmIvK2UrRUM1Z1BHQ3N1ekhxOHorZWRUa3gvaTY2Nmo3WWVk?= =?utf-8?B?YjF3WFpKbXpIeCtyb2gza0Q4Y21SS3dKSko1ZGtqb3RWS1UrMDdJaWIxVm1m?= =?utf-8?B?MEFaNWQ2bVBpNm5jK0d2dWNjMjE5SWFBaUwxcUo2dGFXR2FVK3k1MWovT3Er?= =?utf-8?B?RlJXOGZxNWlQQWZNOFNWWWJSNzNmRjFMbm1rM1VPUVZibW93ODRHOEJnVHV5?= =?utf-8?B?OFdrd3R0dmk0anJ6WFRFRjZoenA2Skh6ZkpFM1FjcWtzc2oxZk1TQ3liQVMw?= =?utf-8?B?UVdaV3ExaHo3VGpRalVRMXRxRk1pV1pEYzJaMHFITGxPOTEwcGZNS0RrNUwz?= =?utf-8?B?SWVYM0Z3T0J0NmVGSC90Qy9udlBDSXJjODBuRlVjSEh4Z1liWktFaWhsYndM?= =?utf-8?B?S3lKZDlldWFvV3RtelZxSlU1WGg2Szhvd0dURFZsd1dmeWxiQ0d6eEVDVkgr?= =?utf-8?B?OW1yZ3NITk4wM0FEZzRtTmh1VlpTbWFuK1g0Y2NsUWUyYmI5Y1JVczRoN0ov?= =?utf-8?B?dkFsRmZaZjVycFNNQXdZOWdxL0RSTGFzcVp3c2tFaHpVM1ljWDVXRWJuK3J5?= =?utf-8?B?RmVySDNsWGpWOTVoWUVzenJzcllHNHdoeUpJRUJidkxHa3pteHlzVm1PTmJI?= =?utf-8?B?Q01pVHNXYlpaVHdwNk9XaUE5c3pxdGhOTXY5a3BtTkdLWEd0c3N6RG55MjRi?= =?utf-8?B?MU9qYnk2cmU3UVIyK2NYd3QxN0tSZkR2cERPZnRKS2hiVWxSc2JCZkV4VjY2?= =?utf-8?B?NWJ6SnV4cHMwREpjQnBwRzFVTk8yVHFRQzJqTys4MDhIMjJUSzViVENpQTUx?= =?utf-8?B?ZkIxNUtHN3g3bldpR1JCaUVvd29jekI1a29YV1lldGVWbG15YXM0VmZyM2hY?= =?utf-8?B?dHg5ZEV0b1FzMisrQnpkSWRNeE0xSUwxc1dtTzNTb2FjZTJTa1o3NW9GR1ls?= =?utf-8?B?NEtLZ09DMWI4Ti9tdlZsSGFJQkxBNWJyUkl5dldhbUY2eGM5WGFnTjE4RXFC?= =?utf-8?B?SXpOSzVMQ2JNb3U4Y0FOaXJOdEU2Qkg0ZlNnRlRTQ092QjN5eU9wVVI5TW45?= =?utf-8?B?VU5WYTRITm1sZXpjcEZtTGVGUDVUOWhIY1dMeExvd3lYamtHM2Uwa0VZVTRD?= =?utf-8?B?enQvMEV3aUdtemRiU0ZHbzlhcWZFUzBjZlVHbVM2UVlNbDNteTVxdnNueWtn?= =?utf-8?B?VWRRQlpzYVUwZzBKaWY5TGYyRVB2K0o1VG8xYjVNYXhORzVDREdmTkJVVDV6?= =?utf-8?B?c1ZCclBjdmdiUTBnNGtjVFFEekRVaXFhWlVnN3V5ZzlOcy9WQTJvNnBpbkd2?= =?utf-8?B?S0xNanhJZkxiamJRVVh1QUJPcU01Z2V6TnV1bmh4bVZoUG1XajlFcUc1b3M3?= =?utf-8?B?ZFBDYWtmWG1YMnJvTW1EN29iY3ovR0tBTStBanE5U0pLSmpuUGJ1b3AxR25Y?= =?utf-8?B?aHN5emNCRXZlaFJZbnVyS2s4NHVCN2djbndEOVplMlJrbGlKTHp1N2FCb0Nk?= =?utf-8?B?S3drTGZFZTRSaXVmNFF3Q0NwaWx0emtXWFlGM2R3YkgwYW9yMFFOR3U2TkxX?= =?utf-8?B?bjJUdjR1THFES29ZeHdTektPZVlneHZvSnZ2eEJ6SSs5cnRuYVNQcm83M3Vo?= =?utf-8?B?T2N3REFKU29ISFRMU1AwL1JmdGpWWmx1VmVHeDQrR2U2OEpndlUxMGNzM04w?= =?utf-8?Q?fTz3fozJ/OrHhj8oUUjgliuOI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9dd0242-fe79-42ef-3441-08dab12a9d2a X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 17:03:01.3796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rjvO9en9Anfxlz/nrDmZzAOq6wVWioMnpQv7x8QA2AyG0jnCsFlsLlFKu7M5ut4j X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5328 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/7/2022 6:43 PM, Andrew Boyer wrote: > Pensando Systems has been acquired by AMD. > Update all copyright strings and email addresses. > > Signed-off-by: Andrew Boyer > --- > MAINTAINERS | 4 ++-- > doc/guides/nics/ionic.rst | 16 ++++++++-------- > doc/guides/rel_notes/release_22_11.rst | 5 +++++ > drivers/net/ionic/ionic.h | 6 +++--- > drivers/net/ionic/ionic_dev.c | 2 +- > drivers/net/ionic/ionic_dev.h | 2 +- > drivers/net/ionic/ionic_ethdev.c | 2 +- > drivers/net/ionic/ionic_ethdev.h | 2 +- > drivers/net/ionic/ionic_if.h | 2 +- > drivers/net/ionic/ionic_lif.c | 2 +- > drivers/net/ionic/ionic_lif.h | 2 +- > drivers/net/ionic/ionic_logs.h | 2 +- > drivers/net/ionic/ionic_mac_api.c | 2 +- > drivers/net/ionic/ionic_mac_api.h | 2 +- > drivers/net/ionic/ionic_main.c | 2 +- > drivers/net/ionic/ionic_osdep.h | 2 +- > drivers/net/ionic/ionic_regs.h | 2 +- > drivers/net/ionic/ionic_rx_filter.c | 2 +- > drivers/net/ionic/ionic_rx_filter.h | 2 +- > drivers/net/ionic/ionic_rxtx.c | 2 +- > drivers/net/ionic/ionic_rxtx.h | 2 +- > drivers/net/ionic/meson.build | 2 +- > 22 files changed, 36 insertions(+), 31 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 08e575faac..f2f7f33d1f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -895,8 +895,8 @@ F: doc/guides/nics/pfe.rst > F: drivers/net/pfe/ > F: doc/guides/nics/features/pfe.ini > > -Pensando ionic > -M: Andrew Boyer > +AMD Pensando ionic > +M: Andrew Boyer > F: drivers/net/ionic/ > F: doc/guides/nics/ionic.rst > F: doc/guides/nics/features/ionic.ini Need to move the block up after other AMD driver, since it is sorted alphabetically. > diff --git a/doc/guides/nics/ionic.rst b/doc/guides/nics/ionic.rst > index 673700d6ce..24b57fc0f5 100644 > --- a/doc/guides/nics/ionic.rst > +++ b/doc/guides/nics/ionic.rst > @@ -1,22 +1,22 @@ > .. SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) > - Copyright(c) 2018-2020 Pensando Systems, Inc. All rights reserved. > + Copyright 2018-2022 Advanced Micro Devices, Inc. All Rights Reserved. > > IONIC Driver > ============ > > -The ionic driver provides support for Pensando server adapters. > +The ionic driver provides support for AMD Pensando server adapters. > It currently supports the below models: > > -- DSC-25 dual-port 25G Distributed Services Card `(pdf) `__ > -- DSC-100 dual-port 100G Distributed Services Card `(pdf) `__ > +- DSC-25 dual-port 25G Distributed Services Card > +- DSC-100 dual-port 100G Distributed Services Card > +- DSC-200 dual-port 200G Distributed Services Card `(pdf) `__ This 'DSC-200' support seems an addition, can you please separate it from this patch. > > -Please visit the Pensando web site at https://pensando.io for more information. > -The `Documents `_ page contains Product Briefs and other product information. > +Please visit the AMD Pensando web site at https://www.amd.com/en/accelerators/pensando for more information. > > Identifying the Adapter > ----------------------- > > -To determine if one or more Pensando DSC Ethernet devices are installed > +To determine if one or more AMD Pensando DSC Ethernet devices are installed > on the host, check for the PCI devices: > > .. code-block:: console > @@ -30,7 +30,7 @@ Firmware Support > > The ionic PMD requires firmware which supports 16 segment transmit SGLs. > This support was added prior to version 1.0. For help upgrading older versions, > -please contact Pensando support. > +please contact AMD Pensando support. > > Building DPDK > ------------- > diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst > index 980c91d5d8..552cc5b62c 100644 > --- a/doc/guides/rel_notes/release_22_11.rst > +++ b/doc/guides/rel_notes/release_22_11.rst > @@ -78,6 +78,11 @@ New Features > > * Added support to set device link down/up. > > +* **Updated AMD Pensando ionic driver.** > + > + Updated the ionic PMD with new features and improvements, including: > + > + * Updated to reflect that Pensando has been acquired by AMD. > Need to move this block, to sort it alphabetically in the network drivers group. > Removed Items > ------------- > diff --git a/drivers/net/ionic/ionic.h b/drivers/net/ionic/ionic.h > index a55202b178..31837f050d 100644 > --- a/drivers/net/ionic/ionic.h > +++ b/drivers/net/ionic/ionic.h > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) > - * Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved. > + * Copyright 2018-2022 Advanced Micro Devices, Inc. All Rights Reserved. > */ > > #ifndef _IONIC_H_ > @@ -15,8 +15,8 @@ > #include "ionic_osdep.h" > > #define IONIC_DRV_NAME "ionic" > -#define IONIC_DRV_DESCRIPTION "Pensando Ethernet NIC Driver" > -#define IONIC_DRV_VERSION "0.11.0-49" > +#define IONIC_DRV_DESCRIPTION "AMD Pensando Ethernet NIC Driver" > +#define IONIC_DRV_VERSION "1.17.0-65" If there is a driver version change, can you please make it in different patch that clarifies the change of the version, unless this version change is purely because of company change but I doubt that is the case. > > /* Vendor ID */ > #define IONIC_PENSANDO_VENDOR_ID 0x1dd8 > diff --git a/drivers/net/ionic/ionic_dev.c b/drivers/net/ionic/ionic_dev.c > index 5439b99b2d..a266ea7ddf 100644 > --- a/drivers/net/ionic/ionic_dev.c > +++ b/drivers/net/ionic/ionic_dev.c > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) > - * Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved. > + * Copyright 2018-2022 Advanced Micro Devices, Inc. All Rights Reserved. I am not sure what is the additional benefit of the "All Rights Reserved." note when there is copyright and license in place, but it is common to have that note in separate line after Coypright line. Making it consistent can be helpful in the future if we have scripts to parse the copyright lines etc.. If not blocked by the legal, can you please move the "All Rights Reserved." to the next line below copyright? And if possible, can you please question if "All Rights Reserved." line is required at all?