From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 4587F2C52 for ; Fri, 9 Sep 2016 09:36:18 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id w12so16180557wmf.0 for ; Fri, 09 Sep 2016 00:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=nqR+UgVsGF6Q55SzSjF3UWMqRfqiigdvvlF8BvjVdVE=; b=eLVad4igfhKGJ1FMEfaImOyjupCp/ulKDlh7ZYG+PilMGYdSewMrFQbDvJ/00eUOlj y8Ebxn5E11iwziOnHYBBWuK5Ec5lfvXKvZvQcGJUqRf/c7Yf6oG80uATjpu51jPdO+41 7ySrx8m9KXabh/nVV7GZTHwt32CmB1CsGopXkIGv4HBV8s0KS3b30MBtQDKFbAQCnQac 8Uq0VAgHGvC3pZ7XuQaWOYs9l49lA60jDlxrOrgwoHWTqoBO4hBoGYHcOSDvqc7AvuGd cXD5IkoofZVTQ2Zio4Tj6LIZjN0p9cfZFHV+HSVy9JGztXr4Ee8yL20J6rF9SY89S+j3 HnVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=nqR+UgVsGF6Q55SzSjF3UWMqRfqiigdvvlF8BvjVdVE=; b=TM2TBj243V4nwYKreedqI0DwxCNC5VxkcnmB8/sn10V73/IhU34nQ7xZ6j50FIUxlP MsYBxLX8Dx/wq9qSQqAeJ4Xj/xYsJ2c4HsoVe9uQRGpiEkSMPtlgS9tt8yz8pp81cbgA AU3Xq+zxHZyS80pp6Iyxzj+zCtI0/LkTtEvJptbowMomiGiyLH61qZ5MzzTwk77q2M9O zLlfpBCpgPanvDd4Bxnq1pZJ4Ce/0X9DtRrl1/pMm1Nt66L6xEO2eC6eklPuXRvCPrsj wME328Ey9UE9Bz/tyVn/yAYyFXPXBqum6GCVitmhZvl0J0XAvzIeKbAjzsfmQe4kwkFr 1uhA== X-Gm-Message-State: AE9vXwOONZIgjVSHDc0cqBclGrZe26pCn0K5ykMnXVj/qHRo2Sc5nGTncJlyi3U8QPuwFY+n X-Received: by 10.194.243.10 with SMTP id wu10mr1627822wjc.130.1473406578046; Fri, 09 Sep 2016 00:36:18 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id t202sm1912683wmt.22.2016.09.09.00.36.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Sep 2016 00:36:17 -0700 (PDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Bruce Richardson , dev@dpdk.org Date: Fri, 09 Sep 2016 09:36:16 +0200 Message-ID: <23402357.BqYEcGSZAq@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1473157994-25101-1-git-send-email-ferruh.yigit@intel.com> <1794333.caoKPGO1RT@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/kni: add KNI PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 07:36:18 -0000 2016-09-08 19:11, Ferruh Yigit: > On 9/8/2016 10:38 AM, Thomas Monjalon wrote: > > 2016-09-08 10:25, Bruce Richardson: > >> On Thu, Sep 08, 2016 at 09:44:55AM +0200, Thomas Monjalon wrote: > >>> 2016-09-06 11:33, Ferruh Yigit: > >>>> Add KNI PMD which wraps librte_kni for ease of use. > >>>> > >>>> KNI PMD can be used as any regular PMD to send / receive packets to the > >>>> Linux networking stack. > >>> > >>> Good move! > >>> Why not deprecate librte_kni and move all the code in the PMD later? > >> > >> +1 to this plan. However, I don't think it all needs to be done in one patchset, > >> though, does it? > > > > I think the deprecation notice must be in this patchset along with some > > __rte_deprecated in front of librte_kni functions. > > Then the move of the library in the PMD could be done in the next release. > > > > Not sure about deprecating librte_kni, this means existing KNI > applications needs to be updated. What is the benefit of this effort? > > Also librte_kni supports more than what PMD does, like PMD doesn't have > ethtool support or binding kernel threads, it uses hardcoded mbuf_size... > > I was thinking PMD as a data only, simplified use case of library. OK, thanks for the clarification.