From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1C15A0547; Wed, 21 Apr 2021 21:43:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AF3E40687; Wed, 21 Apr 2021 21:43:53 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id A280E40150 for ; Wed, 21 Apr 2021 21:43:51 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id D36AC5808C9; Wed, 21 Apr 2021 15:43:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 21 Apr 2021 15:43:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ObnRIObpeo7XF6EZ2283YRZfcp2lgPo5Twz7RyemzTw=; b=VjiC3I+vwhCIJBGE b4alYgPiRMenfXPg8SxapY+PAFjeeZE8khxUljT6k9RG1apuUvT+vsHtcSuwSFVb cbaghDlMT7mrgEPLJgAr2ML5Qga7Z9gWgpb+NfkVkhsNb1Ugqi+cc2gwrgsB2mou 0Zmzciu4jXb+MaZD0udsKsNL6pmRVkOf2vElRiGEhzFizEHhj3Ao+5sCIFThqRVk 6lKAvbmh2zx1Jb+SwczgSSRxQY58PmFpJUnrSVFEVMrEjjY0dHY+GEP3X5BHLYe7 1S+xrwicLgrHGv7tKawRWN2rD6SDJ05yHVsY7gZrSxK8DsxkDlPNM+uALyqHYDoZ i/pGkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ObnRIObpeo7XF6EZ2283YRZfcp2lgPo5Twz7Ryemz Tw=; b=qP8jCHob41uHrwz2oiLSL/o0oZYBOhUw/f9G3EP8ckrbSl3XQzdbeYHf8 vRDYUs2lBH6xEjQXRr/MlE7EXpDMI11rYej/BJfLzUsnMHq8Uu/9yiSc+U4UPoo1 s6OhbSb5VTIaGa84qpAOXPV/NCkHgkhDw/6dJr5GCmgBDUefAa/UZsEHODiZKqgh vneWbvfxuAOsgl9tM5eH8HWJRP/Ja5ocuifBW3wboheaY8uT6WjWHqkuMpdejT+R 2PrN/dCvP68W9F7ftjUgxGSM8UvmJkoUFwV9weG6pQbPs9J+haa4njCF0YiJjEIX RESujRNVMHuqpaYo21NhrSQd83q1Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtkedgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0448B108005B; Wed, 21 Apr 2021 15:43:47 -0400 (EDT) From: Thomas Monjalon To: Jiawei Wang Cc: matan@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, shahafs@nvidia.com, ferruh.yigit@intel.com, Wisam Jaddo , Xiaoyun Li , Jasvinder Singh , Cristian Dumitrescu , Andrew Rybchenko , Ray Kinsella , dev@dpdk.org, rasland@nvidia.com, roniba@nvidia.com, asafp@nvidia.com, Li Zhang , Haifei Luo Date: Wed, 21 Apr 2021 21:43:45 +0200 Message-ID: <23466981.2A24ZmSzZz@thomas> In-Reply-To: <1618927490-229267-2-git-send-email-jiaweiw@nvidia.com> References: <1618848506-37569-1-git-send-email-jiaweiw@nvidia.com> <1618927490-229267-1-git-send-email-jiaweiw@nvidia.com> <1618927490-229267-2-git-send-email-jiaweiw@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/04/2021 16:04, Jiawei Wang: > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -244,6 +244,27 @@ New Features > * Added support for crypto adapter forward mode in octeontx2 event and crypto > device driver. > > + * deleted the port meter policer action command . > + ``set port meter policer action (port_id) (mtr_id) (action_mask) ...`` > + * Added command to create meter policy. > + ``add port meter policy (port_id) (policy_id) g_actions {action} end y_actions {action} end r_actions {action} end`` > + * Added command to delete meter policy. > + ``del port meter policy (port_id) (policy_id)`` > + > +* **Updated meter API.** > + > + * ethdev: Deleted meter policer API to support policy API. > + ``rte_mtr_policer_actions_update()`` > + * ethdev: Added meter API to support pre-defined policy, rte_flow action list per color. > + ``rte_mtr_meter_policy_add()``, ``rte_mtr_meter_policy_delete()`` and > + ``rte_mtr_create_with_policy()`` > + * ethdev: Removed rte_mtr_policer_action from rte_mtr_params structures. > + * ethdev: Added rte_mtr_meter_policy_params structures to support policy API. > + * ethdev: Added meter_policy_id into rte_mtr_params structures. > + * ethdev: Removed policer_action_recolor_supported and policer_action_drop_supported from rte_mtr_capabilities structures. > + * ethdev: Added meter_policy_n_max into rte_mtr_capabilities structures. > + * ethdev: Added RTE_FLOW_ACTION_TYPE_METER_COLOR in enum rte_flow_action_type. > + * ethdev: Added RTE_MTR_ERROR_TYPE_METER_POLICY_ID and RTE_MTR_ERROR_TYPE_METER_POLICY_ID into rte_mtr_error_type. What is this garbage? Wrong place, wrong format, wrong everything. I would like to see a bit more attention to details, especially in a rush to close the -rc1.