From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
 [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id D19A97EF8
 for <dev@dpdk.org>; Thu,  9 Oct 2014 21:03:21 +0200 (CEST)
Received: by mail-wi0-f171.google.com with SMTP id em10so14096505wid.10
 for <dev@dpdk.org>; Thu, 09 Oct 2014 12:10:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=zr7FEiVDRgMMkQdbSggTOi4YY0EypFA8vKj8v+pS9Wk=;
 b=JoLd8fYlxxhQqvwfCwKgaqnw1feiRzrWlfVDI5GItel55DK6FAKXZI8TyXJzOrSVyY
 Pz2CTivWUKemoQW4gPCkXX0FHeCmGBeGE7WN1enC9kZLsYtBaAQzwUHzWFZb3csfwKwS
 nyKc/+yRhAG7kx4tNQ6pCqXmgCBz8QB22eNyrUZj1VULS/r7uI7gDl6tteBBkdkCOY98
 lhpV8Uh/W224+f1dsaEpwHn1k34Oy9uSudsdtq52bDM8mUr0nop7C4ne9+J0kejF33T3
 PZJF5fiYcLcmxTVXedNoOdLPDAW4CVWEWvl6j0jk40J6nhCb9EEqJ9UCD6AAhjosgahV
 Xe9Q==
X-Gm-Message-State: ALoCoQkCrXpleAhIVWYcknFkAES+LwJ5AUnJ+cZNjbEKL+djK/WSi10DtywDfIZMeArv0fOwzNst
X-Received: by 10.194.47.161 with SMTP id e1mr6185500wjn.92.1412881844715;
 Thu, 09 Oct 2014 12:10:44 -0700 (PDT)
Received: from xps13.localnet (15.21.90.92.rev.sfr.net. [92.90.21.15])
 by mx.google.com with ESMTPSA id x6sm3306114wif.0.2014.10.09.12.10.42
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Oct 2014 12:10:44 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: =?ISO-8859-1?Q?Nicol=E1s?= Pernas Maradei <nico@emutex.com>
Date: Thu, 09 Oct 2014 21:10:21 +0200
Message-ID: <2347562.QcBRlqmUyU@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <20141006145020.GE22304@hmsreliant.think-freely.org>
References: <20141006145020.GE22304@hmsreliant.think-freely.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] Fix librte_pmd_pcap driver double stop
	error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Oct 2014 19:03:22 -0000

> > New in Patch v2:
> >=20
> > - Fixes an issue in eth_dev_start/stop where a single interface was=
 always
> > opened/closed even though pcap files had been selected for rx/tx st=
reams.
> > - The link_status was not being properly updated in case of using a=
 single
> > interface for rx/tx streams.
> >=20
> > On 2014-10-04 23:24, Nicol=E1s Pernas Maradei wrote:
> > >
> > >librte_pmd_pcap driver was opening the pcap/interfaces only at ini=
t time
> > >and
> > >closing them only when the port was being stopped. This behaviour =
would
> > >cause
> > >problems (leading to segfault) if the user closed the port 2 times=
. The
> > >first
> > >time the pcap/interfaces would be normally closed but libpcap woul=
d throw
> > >an
> > >error causing a segfault if the closed pcaps/interfaces were close=
d again.
> > >This behaviour is solved by re-openning pcaps/interfaces when the =
port is
> > >started (only if these weren't open already for example at init ti=
me).
> > >
> > >Signed-off-by: Nicol=E1s Pernas Maradei <nico@emutex.com>
>=20
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied

Thanks
--=20
Thomas