From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dev@dpdk.org, "Van Haaren, Harry" <harry.van.haaren@intel.com>,
Pascal Mazon <pascal.mazon@6wind.com>,
Olga Shern <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/tap: use local eBPF definitions
Date: Wed, 24 Jan 2018 19:03:55 +0100 [thread overview]
Message-ID: <2347692.HfTsUKljQz@xps> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FF4B9D@IRSMSX102.ger.corp.intel.com>
24/01/2018 12:05, Van Haaren, Harry:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ophir Munk
> > Sent: Tuesday, January 23, 2018 9:54 PM
> > To: dev@dpdk.org; Pascal Mazon <pascal.mazon@6wind.com>
> > Cc: Thomas Monjalon <thomas@monjalon.net>; Olga Shern <olgas@mellanox.com>;
> > Ophir Munk <ophirmu@mellanox.com>
> > Subject: [dpdk-dev] [PATCH v1] net/tap: use local eBPF definitions
> >
> > eBPF has a graceful approach: it must successfully compile on all Linux
> > distributions. If a specific kernel cannot support eBPF it will gracefully
> > refuse the eBPF netlink message sent to it.
> > The kernel header file linux/bpf.h (if present) on different Linux
> > distributions may not include all definitions required for TAP
> > compilation.
> > In order to guarantee a successful eBPF compilation everywhere all the
> > required definitions for TAP have been locally added instead of including
> > file <linux/bpf.h>
> >
> > Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
>
> Tested on a Fedora 20 vm, uname -r = 3.15.6-200.fc20.x86_64
>
> Confirmed before patch was failing, with patch build is fixed.
>
> Tested-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-01-24 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 21:54 Ophir Munk
2018-01-24 11:05 ` Van Haaren, Harry
2018-01-24 18:03 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2347692.HfTsUKljQz@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).