From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A8C94A0A02;
Thu, 14 Jan 2021 15:34:00 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 864F41412CA;
Thu, 14 Jan 2021 15:34:00 +0100 (CET)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by mails.dpdk.org (Postfix) with ESMTP id 4817E1412C9
for <dev@dpdk.org>; Thu, 14 Jan 2021 15:33:57 +0100 (CET)
IronPort-SDR: nhXc70gvjHcgth/9koo6DvqvnQE9G4fq0eXMcZZsXJEa0Cr6OTPTGDF2ivMt4k/kDAbVhn0TZe
v3TgF9e/8i3A==
X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="175794251"
X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="175794251"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
14 Jan 2021 06:33:57 -0800
IronPort-SDR: aiQGW3+ps/q/8H1R0YLRwp2UliR7mGyoN3DREmTstvhXSrz63sePRNA72+6PjYodiMYmRFd6Bw
fz0+FWO/AqmA==
X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="382284567"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.220.143])
([10.213.220.143])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
14 Jan 2021 06:33:55 -0800
To: Jeff Guo <jia.guo@intel.com>, qi.z.zhang@intel.com,
jingjing.wu@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com
Cc: dev@dpdk.org
References: <20201216085854.7842-1-jia.guo@intel.com>
<20201224065940.76857-1-jia.guo@intel.com>
<20201224065940.76857-3-jia.guo@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <234860dd-14c9-ba66-dfd2-46d1e705fe0a@intel.com>
Date: Thu, 14 Jan 2021 14:33:51 +0000
MIME-Version: 1.0
In-Reply-To: <20201224065940.76857-3-jia.guo@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [dpdk-dev v2 2/2] app/testpmd: add new UDP tunnel
port for ecpri
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 12/24/2020 6:59 AM, Jeff Guo wrote:
> Add new UDP tunnel port params for ecpri configuration, the command
> as below:
>
> testpmd> port config 0 udp_tunnel_port add ecpri 6789
> testpmd> port config 0 udp_tunnel_port rm ecpri 6789
>
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
> app/test-pmd/cmdline.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
Can you please update the 'cmd_help_long_parsed()' for command update,
and update the testpmd documentation, 'testpmd_funcs.rst'?
> index 2ccbaa039e..af08e48e2e 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -9175,6 +9175,8 @@ cmd_cfg_tunnel_udp_port_parsed(void *parsed_result,
> tunnel_udp.prot_type = RTE_TUNNEL_TYPE_GENEVE;
> } else if (!strcmp(res->tunnel_type, "vxlan-gpe")) {
> tunnel_udp.prot_type = RTE_TUNNEL_TYPE_VXLAN_GPE;
> + } else if (!strcmp(res->tunnel_type, "ecpri")) {
> + tunnel_udp.prot_type = RTE_TUNNEL_TYPE_ECPRI;
> } else {
> printf("Invalid tunnel type\n");
> return;
> @@ -9209,7 +9211,7 @@ cmdline_parse_token_string_t cmd_config_tunnel_udp_port_action =
> "add#rm");
> cmdline_parse_token_string_t cmd_config_tunnel_udp_port_tunnel_type =
> TOKEN_STRING_INITIALIZER(struct cmd_config_tunnel_udp_port, tunnel_type,
> - "vxlan#geneve#vxlan-gpe");
> + "vxlan#geneve#vxlan-gpe#ecpri");
> cmdline_parse_token_num_t cmd_config_tunnel_udp_port_value =
> TOKEN_NUM_INITIALIZER(struct cmd_config_tunnel_udp_port, udp_port,
> RTE_UINT16);
> @@ -9217,7 +9219,8 @@ cmdline_parse_token_num_t cmd_config_tunnel_udp_port_value =
> cmdline_parse_inst_t cmd_cfg_tunnel_udp_port = {
> .f = cmd_cfg_tunnel_udp_port_parsed,
> .data = NULL,
> - .help_str = "port config <port_id> udp_tunnel_port add|rm vxlan|geneve|vxlan-gpe <udp_port>",
> + .help_str = "port config <port_id> udp_tunnel_port add|rm vxlan|"
> + "geneve|vxlan-gpe|ecpri <udp_port>",
> .tokens = {
> (void *)&cmd_config_tunnel_udp_port_port,
> (void *)&cmd_config_tunnel_udp_port_config,
>