From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE84045562; Wed, 3 Jul 2024 17:55:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6ECF427B8; Wed, 3 Jul 2024 17:55:09 +0200 (CEST) Received: from fhigh6-smtp.messagingengine.com (fhigh6-smtp.messagingengine.com [103.168.172.157]) by mails.dpdk.org (Postfix) with ESMTP id D454F4111C for ; Wed, 3 Jul 2024 17:55:07 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 413A8114014B; Wed, 3 Jul 2024 11:55:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 03 Jul 2024 11:55:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1720022107; x=1720108507; bh=q1RndA+ohOJl2Gn1+Zzox82UHQt/sIVwW6tE1p8PE0c=; b= WcLShVC1DSlGkFYkk+rVKTQ6uipQRfn5IgJ9J/Sf5E5BnWOTXxjhTEphJEaXCTmY /Yrjjb/hnjgmo5pwtVYxodBZZuEI1beAS5skcYvNmX8eIsIsfoNvv1W9a2O8FOuP h7/nr1wfKXBiYwUYJAbRDj1O7Ect9HVFTTM5mouZiONTKNyL8ZuLLxMnKwhGl5NN ul0LqEAkKjsXWgvxfU4sHZL7XsBUiwAjGo191Sa/CafHDCvc2uhMUy4+f0pY5Gi1 iprDNTmArrQPluPcVCwqePF4EisItdaWW7PbwPNypw0BpuifStBN7LY6k3XMm1ax bj3OwNfrO2DYo4bg73jXOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720022107; x= 1720108507; bh=q1RndA+ohOJl2Gn1+Zzox82UHQt/sIVwW6tE1p8PE0c=; b=p QeUEIx+9/3KHvpmNtD5vroTr4qN1c600bwU22uKpTon28uEkN5IypKHrjqjRc0Li rIe9Ae8RE7zl7xwtcMkhHf256ABmkbxTPDUJ2ItjQkwPbGn3LE/+MOgKDXBguAZO lJqc3ndAhh6lJrLssAAngISmTywLS2NIf8WhAoR26wC2nToDlcyxpD4uFH3SM7Fu 8h3BnXU2Z2isdzNvjVU5c0Hx05BOrCgVGeEzlq9LicdbasnltTNjobhWx0ZjzF4y dpswNsywP4GMWo7Ceq8s3FECZRNk/sQh7sBf5gGu6yL3uNQonvoeFZ4ZJlHnnk0B FvoeEYHXFmJjNSN3Aqhmw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Jul 2024 11:55:06 -0400 (EDT) From: Thomas Monjalon To: Volodymyr Fialko Cc: dev@dpdk.org, "cristian.dumitrescu@intel.com" , Jerin Jacob , Anoob Joseph Subject: Re: [PATCH v5] bitmap: add scan from offset function Date: Wed, 03 Jul 2024 17:55:04 +0200 Message-ID: <2349062.T8it5fGzs6@thomas> In-Reply-To: References: <20230703093130.198304-1-vfialko@marvell.com> <11099356.0mgMEAqHVh@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/07/2024 15:42, Volodymyr Fialko: > > From: Thomas Monjalon > > Sent: Wednesday, July 3, 2024 2:50 PM > > To: Volodymyr Fialko > > Cc: dev@dpdk.org; cristian.dumitrescu@intel.com; Jerin Jacob; Anoob Joseph > > Subject: Re: [PATCH v5] bitmap: add scan from offset function > > > > 03/07/2023 14:39, Volodymyr Fialko: > > > Currently, in the case when we search for a bit set after a particular > > > value, the bitmap has to be scanned from the beginning and > > > rte_bitmap_scan() has to be called multiple times until we hit the value. > > > > > > Add a new rte_bitmap_scan_from_offset() function to initialize scan > > > state at the given offset and perform scan, this will allow getting > > > the next set bit after certain offset within one scan call. > > > > > > Signed-off-by: Volodymyr Fialko > > > --- > > > v2: > > > - added rte_bitmap_scan_from_offset > > > v3: > > > - added note for internal use only for init_at function > > > v4: > > > - marked init_at function as __rte_internal > > > v5: > > > - removed __rte_internal due to build errors > > > > What was the build error? > > > > You should not add an internal function in the public header file. > > At least, it should be experimental. > > > > From our discussion in previous versions(V3, V4), It looks like we agreed to > remove both markers. Indeed, sorry I forgot this discussion.