From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C447A0093; Tue, 8 Nov 2022 12:18:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C4AF40693; Tue, 8 Nov 2022 12:18:10 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 4B827400D4 for ; Tue, 8 Nov 2022 12:18:09 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B821B5C01F7; Tue, 8 Nov 2022 06:18:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 08 Nov 2022 06:18:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1667906287; x= 1667992687; bh=Dbt8VeupOrlqTtMWdkLvPnlm2OPiZ8QQCLaP5e7RSxo=; b=Z zEOF2HHwx6zNnGg4ximD/vdBQrpm7mQ2EQ2jKZGSEYy44ZQK+/CIFuvt2N2Ndorr dt8X2IYgsPeeTIPRnKuJ635Ha+C3Nt9yZGXKVryN3I6LVfRVhrWxLo4UrG9cBOLE ZdMWnyqVG35UfbrtId5ekRHn1tpyXrG/NoDelcczx/t13rpGOHvU34JAj699AYwj eN9+24bvZlFWWXcWY60j/AyyR6hZnasl3QQG/LPvD9EWUT3615xQ0so6kvxlT/Fr 7acFgNtFIsYU9+JuLwGkvnu+BpW7i4cfmI4rImFY608gsJbbWvgxYUPJQ9RwthKj xkaI3F7eL3y2eOykN9BCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1667906287; x= 1667992687; bh=Dbt8VeupOrlqTtMWdkLvPnlm2OPiZ8QQCLaP5e7RSxo=; b=I HLD0O2wQ4gRCyFhy2mH6O8DoEb8mDsWxiQoX446boTdrZNrPg8ZMqzFIlKGdbL7F 8uBuu7GJeiApO2FyHsy1QwfkLZNck7SJdNMAfmDDFMKNXuIA06Mlfaw2Y4dljAUk mYZxerTD5vGlIJwPT3SQEhsIJtX5uDGl7kp2HY6BdhSkrT4NGbQzWBUFHl6eDmZ8 ToIIwXbUqZfc0+gbAzFv50oZ6h9eMlaf6ng8otvxpnNseAqV2IYcX74/WusTUOkV iv2jmmnZ7mcxIk8xaVJVmfpRUat1fAqTiC+C+J5D/J4hjfbMugLzfGvccZCoqBYS aEEeq3IiBnMzDpazojXPA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfedtgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Nov 2022 06:18:05 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko Cc: Rongwei Liu , matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, Aman Singh , Yuying Zhang , Ferruh Yigit , dev@dpdk.org, rasland@nvidia.com Subject: Re: [PATCH v3] ethdev: add hint when creating async transfer table Date: Tue, 08 Nov 2022 12:18:03 +0100 Message-ID: <23493060.RjEADstKbi@thomas> In-Reply-To: <6c59c7e9-2b24-095e-53e6-d0f0744d5681@oktetlabs.ru> References: <5d8d42b2-7011-cb46-7f2c-1b1019c4151e@oktetlabs.ru> <2308337.OYXXYNVTWy@thomas> <6c59c7e9-2b24-095e-53e6-d0f0744d5681@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/11/2022 10:35, Andrew Rybchenko: > On 11/8/22 12:19, Thomas Monjalon wrote: > > 06/11/2022 11:02, Andrew Rybchenko: > >> On 10/4/22 11:31, Andrew Rybchenko wrote: > >>> On 9/28/22 12:24, Rongwei Liu wrote: > >>>> The transfer domain rule is able to match traffic wire/vf > >>>> origin and it means two directions' underlayer resource. > >>>> > >>>> In customer deployments, they usually match only one direction > >>>> traffic in single flow table: either from wire or from vf. > > > > Customer deployment is not an argument. > > > >>>> Introduce one new member transfer_mode into rte_flow_template_table_attr > >>>> to indicate the flow table direction property: from wire, from vf > >>>> or bi-direction(default). > > > > The origin is not a direction. > > We should update this sentence. > > > >>>> It helps to save underlayer memory also on insertion rate, and this > >>>> new field doesn't expose any matching criteira. > > > > Should be reworded. > > > >>>> By default, the transfer domain is to match bi-direction traffic, and > >>>> no behavior changed. > > > > This sentence is confusing, it should be removed. > > > >>>> 1. Match wire origin only > >>>> flow template_table 0 create group 0 priority 0 transfer wire_orig... > >>>> 2. Match vf origin only > >>>> flow template_table 0 create group 0 priority 0 transfer vf_orig... > > > > This testpmd example needs to be introduced with a sentence. > > > >>> Since wire_orig and vf_orig are just optional hints and not > >>> all PMDs are obliged to handle it, it does not impose any > >>> matching criteria. > > > > Yes > > > >>> So, example above are misleading and you > >>> need to add pattern items to highlight that corresponding rules > >>> are really wire_orig or vf_orig. > > > > This is template table creation, so I don't think there is more to add. > > What do you have in mind? > > > > Since origin is just a hint which does not impose any matching > criteria it must be highlighted in example that corresponding > rules must have some pattern items defining corresponding > origin. Yes we could talk about corresponding rules in the commit message. What do you think of the explanations in the doc? > >> I'm sorry, but I still don't see how it is addressed in v4. > > > > I think the documentation in v4 is pretty clear. > > Do you see something in the doc which is confusing? > > The commit message needs rewording though.