From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Cc: dev@dpdk.org, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [dpdk-dev] [PATCH] vchost: Notify application of ownership change
Date: Sat, 24 Oct 2015 19:16:49 +0200 [thread overview]
Message-ID: <2350656.p07ll6Er1F@xps13> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B2BD88C4F@SHSMSX101.ccr.corp.intel.com>
2015-08-12 03:34, Xie, Huawei:
> On 8/8/2015 1:21 AM, Jan Kiszka wrote:
> > On VHOST_*_RESET_OWNER, we reinitialize the device but without telling
> > the application. That will cause crashes when it continues to invoke
> > vhost services on the device. Fix it by calling the destruction hook if
> > the device is still in use.
[...]
> > --- a/lib/librte_vhost/virtio-net.c
> > +++ b/lib/librte_vhost/virtio-net.c
> > @@ -402,6 +402,9 @@ reset_owner(struct vhost_device_ctx ctx)
> >
> > ll_dev = get_config_ll_entry(ctx);
> >
> > + if ((ll_dev->dev.flags & VIRTIO_DEV_RUNNING))
> > + notify_ops->destroy_device(&ll_dev->dev);
>
> To me this patch makes sense here.
> Whether RESET_OWNER is really needed is another question. Whenever the
> vhost itself needs to process the vhost device, we need to notify the
> switch application to remove it from data plane.
Huawei,
some patches have been accepted for RESET_OWNER management.
Is this patch obsolete?
next prev parent reply other threads:[~2015-10-24 17:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 17:20 Jan Kiszka
2015-08-08 0:25 ` Ouyang, Changchun
2015-08-08 6:43 ` Jan Kiszka
2015-08-10 1:20 ` Ouyang, Changchun
2015-08-10 8:07 ` Jan Kiszka
2015-08-12 3:34 ` Xie, Huawei
2015-08-12 5:35 ` Jan Kiszka
2015-10-24 17:16 ` Thomas Monjalon [this message]
2015-10-26 5:54 ` Tetsuya Mukawa
2015-10-26 6:30 ` Yuanhan Liu
2015-10-26 8:33 ` Tetsuya Mukawa
2016-03-17 14:42 ` Thomas Monjalon
2016-03-17 14:53 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2350656.p07ll6Er1F@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).