DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>,
	Ophir Munk <ophirmu@mellanox.com>
Cc: Ray Kinsella <mdr@ashroe.eu>, dev <dev@dpdk.org>,
	Raslan Darawsheh <rasland@mellanox.com>,
	Matan Azrad <matan@mellanox.com>,
	Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail
Date: Wed, 06 May 2020 14:52:15 +0200	[thread overview]
Message-ID: <2351387.Sgy9Pd6rRy@thomas> (raw)
In-Reply-To: <CAJFAV8w1=mHzhvEhXJAeqx8FfP5nP5nBFLZ_Kg37vgOqSjSrhA@mail.gmail.com>

06/05/2020 14:42, David Marchand:
> On Wed, May 6, 2020 at 2:27 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 05/05/2020 16:53, David Marchand:
> > > On Tue, May 5, 2020 at 1:21 PM Ophir Munk <ophirmu@mellanox.com> wrote:
> > > > +; These functions were moved from stable to internal.
> > > > +; This is a temporary exception till DPDK 20.11.
> > >
> > > This is not until 20.11 if we merge this patch now.
> > > It is only when comparing 20.02 to 20.05.
> > > After this, symbols will be marked INTERNAL and will be skipped by the
> > > generic rule, so we can remove this exception in 20.08-rc0.
> >
> > I think we need to keep this rule until 20.11,
> > because we want to ignore symbols which were in 19.11 and 20.02,
> > and removed (as internal) in 20.05.
> 
> Those symbols were exported in 20.02.

Right, no issue when comparing with 19.11.


> Before this, they were internal to mlx5 net driver.
> 
> 
> >
> > If we remove this rule in 20.08, and comparing with 19.11,
> > the tool will complain about removed symbols, isn't it?
> 
> If we remove the rule in 20.08 and compare to _20.02_ then yes, we
> would get an issue.
> I was only thinking of comparing 20.08 with 20.05.
> 
> We can keep this until 20.11 if you think it is safer.

Yes I think we must make sure any comparison can be done during
compatibility lifetime.



  reply	other threads:[~2020-05-06 12:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 11:20 Ophir Munk
2020-05-05 11:20 ` [dpdk-dev] [PATCH v1 2/3] common/mlx5: add rte internal tag Ophir Munk
2020-05-05 11:46   ` Matan Azrad
2020-05-05 11:20 ` [dpdk-dev] [PATCH v1 3/3] common/mlx5: remove devx dependency on ibv and DV Ophir Munk
2020-05-05 11:45 ` [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail Matan Azrad
2020-05-05 14:53 ` David Marchand
2020-05-05 15:02   ` Ray Kinsella
2020-05-06 12:27   ` Thomas Monjalon
2020-05-06 12:42     ` David Marchand
2020-05-06 12:52       ` Thomas Monjalon [this message]
2020-05-06 14:15         ` Ray Kinsella
2020-05-06 14:22           ` Thomas Monjalon
2020-05-07  7:48             ` Ophir Munk
2020-05-07  7:37 ` [dpdk-dev] [PATCH v2 0/2] add INTERNAL tags and avoid comparison Ophir Munk
2020-05-07  7:37   ` [dpdk-dev] [PATCH v2 1/2] common/mlx5: add rte internal tag " Ophir Munk
2020-05-07  7:44     ` Matan Azrad
2020-05-07  7:56     ` Ray Kinsella
2020-05-07  9:03       ` Ophir Munk
2020-05-07  8:56     ` [dpdk-dev] [PATCH v3 " Ophir Munk
2020-05-07  8:56       ` [dpdk-dev] [PATCH v3 2/2] common/mlx5: remove devx dependency on ibv and DV Ophir Munk
2020-05-07 10:23       ` [dpdk-dev] [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison Thomas Monjalon
2020-05-07 11:41         ` Ophir Munk
2020-05-07 20:08           ` Thomas Monjalon
2020-05-10  8:14             ` Ophir Munk
2020-05-07 11:31       ` [dpdk-dev] [PATCH v4 " Ophir Munk
2020-05-07 11:31         ` [dpdk-dev] [PATCH v4 2/2] common/mlx5: remove devx dependency on ibv and DV Ophir Munk
2020-05-12 10:52         ` [dpdk-dev] [PATCH v4 1/2] common/mlx5: add rte internal tag and avoid comparison Raslan Darawsheh
2020-05-19  9:08         ` Thomas Monjalon
2020-05-07  7:37   ` [dpdk-dev] [PATCH v2 2/2] common/mlx5: remove devx dependency on ibv and DV Ophir Munk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2351387.Sgy9Pd6rRy@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=mdr@ashroe.eu \
    --cc=nhorman@tuxdriver.com \
    --cc=ophirmu@mellanox.com \
    --cc=rasland@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).