From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40DAAA034F; Wed, 6 May 2020 14:52:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26F1B1D9D8; Wed, 6 May 2020 14:52:20 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6B9DE1D91A for ; Wed, 6 May 2020 14:52:18 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id C6A195C005B; Wed, 6 May 2020 08:52:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 06 May 2020 08:52:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= yjhzw+ewvoi/LJKcm4opsaDOsd8mLllPHRuftfBPg+M=; b=tQy0/EIITHFwww9m +k4zj9RvkgbSBa7XeWcWyMwaWTQmXs0IoyyyKzeJNq53a/82B30Q1fGuoTdRRlvY 5j7x3Q2vzKEU6QRCuKQQ4RFG1guIOwYWFBIUATbyiTZ7m6MmIFL81Oow4GKMVMoj sELiwYLMEir33riJzO3KwM8QKJjMLQcylHOM+lQymmZHe3URAYK2GFVElLuymXTO Aw8kmdFXp1b4JnZ1FlUB5XkuUSL2iNyKWfpbQ4/olbdLCCOrvPQPb2cXk1Sg7EPd bBmWaWSnXrPSEGx8LCJwZWlKOuLH/zaiM0vmwzTducal38WkJ4t4J9jVk9GDE942 X/GcPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=yjhzw+ewvoi/LJKcm4opsaDOsd8mLllPHRuftfBPg +M=; b=G9O6A8Rc5VM8CjoT9IkuQGW4OrJzqbFMmv8VkWO28t7Kl8IEYzUEI10aS KPQ4TarfHzCIdc9O0U6wogtVmip143NjzETCalzr/hX7sb24koU0oGG5btfFl+eG O5GxxGNFyiIzK8a7KP5l6j5b87vxj6TDNZXU87ydN3vsyreke45E8nor8cz232Er 3HYCmSZAilJJ562RE+thVTSia74gDryZwzR2Izu/tvC7pOBf1NQu9z93XOKKuHb7 How34RFVYcXsWGs8+6CHBDbAjLW+DbP0/uVnpc4lseVvkR+xZCKKuKhVlIo7731L N+zxGoaPRCAg0wO+lABpcmYABQY1Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeekgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 55FAC3280070; Wed, 6 May 2020 08:52:16 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Ophir Munk Cc: Ray Kinsella , dev , Raslan Darawsheh , Matan Azrad , Neil Horman Date: Wed, 06 May 2020 14:52:15 +0200 Message-ID: <2351387.Sgy9Pd6rRy@thomas> In-Reply-To: References: <20200505112057.20901-1-ophirmu@mellanox.com> <8275970.VV5PYv0bhD@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/05/2020 14:42, David Marchand: > On Wed, May 6, 2020 at 2:27 PM Thomas Monjalon wrote: > > > > 05/05/2020 16:53, David Marchand: > > > On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: > > > > +; These functions were moved from stable to internal. > > > > +; This is a temporary exception till DPDK 20.11. > > > > > > This is not until 20.11 if we merge this patch now. > > > It is only when comparing 20.02 to 20.05. > > > After this, symbols will be marked INTERNAL and will be skipped by the > > > generic rule, so we can remove this exception in 20.08-rc0. > > > > I think we need to keep this rule until 20.11, > > because we want to ignore symbols which were in 19.11 and 20.02, > > and removed (as internal) in 20.05. > > Those symbols were exported in 20.02. Right, no issue when comparing with 19.11. > Before this, they were internal to mlx5 net driver. > > > > > > If we remove this rule in 20.08, and comparing with 19.11, > > the tool will complain about removed symbols, isn't it? > > If we remove the rule in 20.08 and compare to _20.02_ then yes, we > would get an issue. > I was only thinking of comparing 20.08 with 20.05. > > We can keep this until 20.11 if you think it is safer. Yes I think we must make sure any comparison can be done during compatibility lifetime.