From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id CFEA4231C for ; Thu, 29 May 2014 08:50:00 +0200 (CEST) Received: by mail-wg0-f42.google.com with SMTP id y10so12023907wgg.1 for ; Wed, 28 May 2014 23:50:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=YGcblDQhhYoG2lQRO2FfeWEbxNMX+xsVivfOryJEqHQ=; b=HpDFd7XzHaccMKRK+WysGNkZnM5ntlj7+MiS56SdlYudHHphTM5dxSjuzVKE9SSwNi NhVjyh41th5xHVC+sgBYjDg/U+RqPIHynrn6VE8p7JcsEUr6eOaz0lhaMCCzq9a/le3U 75as2j/q7zV2fNp346UFRhdjN8lt4qeWLktx6nLCndVZQBUcPF97sgjE1v5uk6gmgYEG CXm9Luy/KcVtd+E8GMbVYpJSELCU5fSLST9nDx8lQXQePpbEVYmP3iuRTlgC2UmFJEfM 2fBp9NRaaZ/8KpySeOBub3i0xJWqCnnQz7hMEIlHA0jDgpkI6koGM4nqH9/kI930RDMo oVTA== X-Gm-Message-State: ALoCoQlAXLGP4H0oGDq0gpHFNG+VRGWxsgL9JQ9UPtcuQgB2SSQGQ0ICzuPpavB1YfNc4K48EZL+ X-Received: by 10.180.99.166 with SMTP id er6mr8499380wib.48.1401346212055; Wed, 28 May 2014 23:50:12 -0700 (PDT) Received: from xps13.localnet (108.26.90.92.rev.sfr.net. [92.90.26.108]) by mx.google.com with ESMTPSA id fi2sm23122171wib.2.2014.05.28.23.49.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 May 2014 23:50:11 -0700 (PDT) From: Thomas Monjalon To: Olivier MATZ Date: Thu, 29 May 2014 08:48:39 +0200 Message-ID: <2352405.jTgRhv3zRV@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <5385CCE8.6030501@6wind.com> References: <1401195316-31149-1-git-send-email-thomas.monjalon@6wind.com> <5385CCE8.6030501@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix link with gcc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 May 2014 06:50:01 -0000 Hi Olivier, 2014-05-28 13:47, Olivier MATZ: > On 05/27/2014 02:55 PM, Thomas Monjalon wrote: > > Some linker options were not prefixed by -Wl, when using gcc: > > =09-z muldefs > > =09-melf_i386 (32-bit config) > >=20 > > Using macro linkerprefix is fixing it. > >=20 > > Signed-off-by: Thomas Monjalon >=20 > The patch looks correct, but from the commit log it's difficult > to understand what is the problem today. Is there a compilation > issue? Or is it just cleaning? You're right, title should be: =09mk: fix 32-bit link with gcc And I should add some details in the commit log: I didn't see any error with -z muldefs but it isn't documented in gcc m= anual.=20 So it's safer to explicitly pass it to the linker. The variable CPU_LDFLAGS contains "-melf_i386" in 32-bit configurations= . So=20 building 32-bit shared library raises this error: =09gcc: error: unrecognized command line option =E2=80=98-melf_i386=E2=80= =99 Olivier, I'll make these changes if you (or Neil) ack the patch. Thanks for review --=20 Thomas