From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 800D62B87 for ; Thu, 7 Mar 2019 09:46:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4211D366E; Thu, 7 Mar 2019 03:46:02 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 07 Mar 2019 03:46:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=S1G66NphNrBXs/oy+WEpeW76SLI1FbP1dRmWszfm+Lg=; b=o6DUEuxtHmT1 hRugNF7QklEWfcFjwHOEQnfR+m4rGxzywl9j+E7zjdlfxq+WyYVOHfFasFECWe6U DQ95BCVXsqpyjL7OMM3IxMZaq2TMTpn7S4kNztRAruYgTTk1N+n2WKaGIeyFUg1l vxN2gJFfjMF526hp8+f6PK7QqMa5pRA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=S1G66NphNrBXs/oy+WEpeW76SLI1FbP1dRmWszfm+ Lg=; b=Z1FIQEPeb96P2wl4sqk9bv1mLPUVc9rj10+Vpatvgaf6x+m6YVY5DXvbC OvvjavK5KpEHI3+tv2rHMn7cB1mP0OJyXEshHicGAj7UiBSnJdyKw54KQliSvp3D 4yDUTeDYpwItGOlW503fbBhqLViA/N6AKGxhsiiZlgzKCIHSSKDoyQghwawPwlyR 5BHn0mT9rRaBkTNBiSFphVZdWQOdRpku78iWgP9XpViHHZD43yHLitE+ywI12iHF gCqHEsPzTfz1CuyMjvOxaJopnwAo5tHZT/mgiac/xGYE/HlhdUVdbYbbsjKpoFVx eBINdBw66LYH7fWsNylCIJ9YXBDqQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeejgdduvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeifrhhonhhgrddqqddquggvvhenucfkphepjeejrddufeegrddvtdefrddu keegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9181B10340; Thu, 7 Mar 2019 03:46:00 -0500 (EST) From: Thomas Monjalon To: Anand Rawat Cc: "dev@dpdk.org" , "Kadam, Pallavi" , "Menon, Ranjit" , "Shaw, Jeffrey B" Date: Thu, 07 Mar 2019 09:45:57 +0100 Message-ID: <2354479.T0gxW44koM@xps> In-Reply-To: <97a6242f-6d56-0c12-aba0-5e1f4c609a49@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <2585800.7Z22QRaGj1@xps> <97a6242f-6d56-0c12-aba0-5e1f4c609a49@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 08:46:05 -0000 07/03/2019 04:27, Anand Rawat: > On 3/6/2019 3:31 AM, Thomas Monjalon wrote: > > 06/03/2019 05:16, Anand Rawat: > >> Added header files to support windows on x86 platforms. > >> Updated rte_config to include rte_windows.h for windows > >> build. > > [...] > >> --- a/config/rte_config.h > >> +++ b/config/rte_config.h > >> +/* windows specific*/ > >> +#ifdef RTE_EXEC_ENV_WINDOWS > >> +#include > >> +#endif > > > > Include in the config file looks wrong. > > >> --- /dev/null > >> +++ b/lib/librte_eal/windows/eal/include/exec-env/rte_windows.h > > > > I think we could remove the sub-directory exec-env. > > Could we include this file from rte_common.h? > rte_windows.h defines types and substitution macros which are > needed to support common code on windows. So it should be > included as a global include for every library on windows. > rte_common.h is not included in all the source code and headers > we currently build for windows. I think it is not an issue adding some rte_common.h include here and there.