From: Thomas Monjalon <thomas@monjalon.net>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org, harry.van.haaren@intel.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v4] service: fix parameter type
Date: Thu, 28 Mar 2019 21:10:14 +0100 [thread overview]
Message-ID: <2355503.thBRjjl5CD@xps> (raw)
In-Reply-To: <1553754543-40534-1-git-send-email-nikhil.rao@intel.com>
28/03/2019 07:29, Nikhil Rao:
> The type of value parameter to rte_service_attr_get
> should be uint64_t *, since the attributes
> are of type uint64_t.
>
> Fixes: 4d55194d76a4 ("service: add attribute get function")
>
> Reviewed-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
Rebased for master and applied, thanks.
next prev parent reply other threads:[~2019-03-28 20:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 14:01 [dpdk-dev] [PATCH] " Nikhil Rao
2019-01-21 11:43 ` Van Haaren, Harry
2019-02-08 15:01 ` Ferruh Yigit
2019-02-14 9:56 ` [dpdk-dev] [PATCH v2] " Nikhil Rao
2019-02-15 10:29 ` [dpdk-dev] [PATCH v3] " Nikhil Rao
2019-02-18 20:27 ` Rami Rosen
2019-03-27 9:52 ` Thomas Monjalon
2019-03-27 9:52 ` Thomas Monjalon
2019-03-28 6:29 ` [dpdk-dev] [PATCH v4] " Nikhil Rao
2019-03-28 6:29 ` Nikhil Rao
2019-03-28 20:10 ` Thomas Monjalon [this message]
2019-03-28 20:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2355503.thBRjjl5CD@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).