From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1BBCA2C24 for ; Thu, 28 Mar 2019 21:10:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 794002210C; Thu, 28 Mar 2019 16:10:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 16:10:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=AtWngiy8KhJGVmoj8ExUzjctYqG+WEizPTQYjDmU+fU=; b=PPZcXQfptpm4 o/sKQa7sJlwnJJJirEedJTNEmeGjVNr90OLMoBIlO1a22eGF8L5NFEOqkrvoPF8K E0SGknxl6NMjuObjzJqw/d8w2+ngm/tt3ZCA59sIvxE7snucziDBplyH2Cp1QZfL /N8iTDCd0H8eBHKOTWG1sk5xBbSSgVE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=AtWngiy8KhJGVmoj8ExUzjctYqG+WEizPTQYjDmU+ fU=; b=IzYrklwRsbwcqL91WgavylW0NYZ/4dywgGtVO6ZBXUpX1CW3DHCUo/0pW KZbhLVrrxYTj4wHvPB61nZOZp8z9xKpEuGdF/PtcbUOglT+DJHvJ96/tJO6TRMDn TCRBvhZhHYXuol3xVJWVU8R+Wex/OyDe7QC1xUBpEbOaxxA2sfWmWJSGmy9H2ymK VVz5HqxbDd1RiiCx16O+oKgyXAZKdaDd9C/cLOYTxGlravKE48bnoN0bHMalKJnl F1W4SD/BWnU0h8hxcsnNLNl+Trw5bQFKHEFo31kE13NsO74jWJrcZYqIQT2fj8xf OfWuKgKT62Fatj7gY4cnFQyzFzA0A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeeggddufeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3CD8F10392; Thu, 28 Mar 2019 16:10:15 -0400 (EDT) From: Thomas Monjalon To: Nikhil Rao Cc: dev@dpdk.org, harry.van.haaren@intel.com, ferruh.yigit@intel.com Date: Thu, 28 Mar 2019 21:10:14 +0100 Message-ID: <2355503.thBRjjl5CD@xps> In-Reply-To: <1553754543-40534-1-git-send-email-nikhil.rao@intel.com> References: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com> <1553754543-40534-1-git-send-email-nikhil.rao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] service: fix parameter type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 20:10:17 -0000 28/03/2019 07:29, Nikhil Rao: > The type of value parameter to rte_service_attr_get > should be uint64_t *, since the attributes > are of type uint64_t. > > Fixes: 4d55194d76a4 ("service: add attribute get function") > > Reviewed-by: Gage Eads > Signed-off-by: Nikhil Rao > Acked-by: Harry van Haaren > Reviewed-by: Rami Rosen Rebased for master and applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 29C20A0679 for ; Thu, 28 Mar 2019 21:10:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25C002C54; Thu, 28 Mar 2019 21:10:18 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1BBCA2C24 for ; Thu, 28 Mar 2019 21:10:17 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 794002210C; Thu, 28 Mar 2019 16:10:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 16:10:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=AtWngiy8KhJGVmoj8ExUzjctYqG+WEizPTQYjDmU+fU=; b=PPZcXQfptpm4 o/sKQa7sJlwnJJJirEedJTNEmeGjVNr90OLMoBIlO1a22eGF8L5NFEOqkrvoPF8K E0SGknxl6NMjuObjzJqw/d8w2+ngm/tt3ZCA59sIvxE7snucziDBplyH2Cp1QZfL /N8iTDCd0H8eBHKOTWG1sk5xBbSSgVE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=AtWngiy8KhJGVmoj8ExUzjctYqG+WEizPTQYjDmU+ fU=; b=IzYrklwRsbwcqL91WgavylW0NYZ/4dywgGtVO6ZBXUpX1CW3DHCUo/0pW KZbhLVrrxYTj4wHvPB61nZOZp8z9xKpEuGdF/PtcbUOglT+DJHvJ96/tJO6TRMDn TCRBvhZhHYXuol3xVJWVU8R+Wex/OyDe7QC1xUBpEbOaxxA2sfWmWJSGmy9H2ymK VVz5HqxbDd1RiiCx16O+oKgyXAZKdaDd9C/cLOYTxGlravKE48bnoN0bHMalKJnl F1W4SD/BWnU0h8hxcsnNLNl+Trw5bQFKHEFo31kE13NsO74jWJrcZYqIQT2fj8xf OfWuKgKT62Fatj7gY4cnFQyzFzA0A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeeggddufeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3CD8F10392; Thu, 28 Mar 2019 16:10:15 -0400 (EDT) From: Thomas Monjalon To: Nikhil Rao Cc: dev@dpdk.org, harry.van.haaren@intel.com, ferruh.yigit@intel.com Date: Thu, 28 Mar 2019 21:10:14 +0100 Message-ID: <2355503.thBRjjl5CD@xps> In-Reply-To: <1553754543-40534-1-git-send-email-nikhil.rao@intel.com> References: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com> <1553754543-40534-1-git-send-email-nikhil.rao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] service: fix parameter type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190328201014.-LVleXqjEckS2imohG1-cw8vZdkt5KBajj5vWt7xe-0@z> 28/03/2019 07:29, Nikhil Rao: > The type of value parameter to rte_service_attr_get > should be uint64_t *, since the attributes > are of type uint64_t. > > Fixes: 4d55194d76a4 ("service: add attribute get function") > > Reviewed-by: Gage Eads > Signed-off-by: Nikhil Rao > Acked-by: Harry van Haaren > Reviewed-by: Rami Rosen Rebased for master and applied, thanks.