From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id EFAD25ABA for ; Mon, 9 Mar 2015 08:59:14 +0100 (CET) Received: by wesw55 with SMTP id w55so9360361wes.2 for ; Mon, 09 Mar 2015 00:59:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=pho6dk6pd2h+16HjnJaqyfxbkpnWjZz8dep103ja2Rw=; b=QgbyEdSTO30gElIHzQOJpHKXK9V4Q/A9NfibQ7hEk0dbnN5eIOXTWz9dEFa2zW4B+E MKTeC5WvAXreJdCSzYldCp1usMbIaI6fj/sSOXFFdldM2zZ9CVsMFAvric5ltRAcoRe2 plJH5SbjRggBKKNAA+5k996q0XWXPA/tyCuysvrQVLFqVDxRkTyUOQxRsEJky/S0CZF9 ZbaUOhRImmseUX1K9BoUzKC4rzpRMFJi2sD/RhwHWh7ZkeaTsPIpHEN/rGXKx7b9KR0K GsJv1yDhT9WXlnA0uySiRkH/SsYdDteYF4t4eDZNta/IcvBP994kWaHaMvRhcgot5bQy Giig== X-Gm-Message-State: ALoCoQk/nsCBTjyOav9/p4Bq2n+2xfY5RbFXpJCI2gV3kjWc3RwOsSjTU598CpLR/fM+Uw/zq+Cr X-Received: by 10.180.75.73 with SMTP id a9mr10064673wiw.45.1425887954819; Mon, 09 Mar 2015 00:59:14 -0700 (PDT) Received: from xps13.localnet (60.26.90.92.rev.sfr.net. [92.90.26.60]) by mx.google.com with ESMTPSA id nd15sm3965464wic.8.2015.03.09.00.59.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 00:59:13 -0700 (PDT) From: Thomas Monjalon To: Vlad Zolotarov Date: Mon, 09 Mar 2015 08:58:37 +0100 Message-ID: <2357467.DFWlgGcAaX@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <54FD46FC.5010608@cloudius-systems.com> References: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com> <3162156.p89LbuxRO9@xps13> <54FD46FC.5010608@cloudius-systems.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 07:59:15 -0000 2015-03-09 09:08, Vlad Zolotarov: > > On 03/08/15 23:12, Thomas Monjalon wrote: > > Hi Vlad, > > > > 2015-03-08 16:04, Vlad Zolotarov: > >> According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should > >> be configured to the same value as HLREG0.RXCRCSTRP. > >> > >> Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec > >> but seems harmless. > >> > >> Signed-off-by: Vlad Zolotarov > > You are mixing a fix (this patch) and enhancements (LRO) in the same series. > > Could you separate them please, as LRO is not going into 2.0 but this fix > > is a good candidate. > > Pls, note that all patches in this series except for PATCH3 and PATCH5 > are fixing real bugs. I can send them as a separate series if u'd like. > Pls., confirm. Yes you're right, patch 1 is also a fix and patch 4 seems to solve other issues. However, patch 4 makes also some refactoring and seems a bit risky. We need an ixgbe maintainer to decide wether we can merge it before the release. Or is it possible to have fixes of the patch 4 without the refactoring? Thanks Vlad. Sorry to request such split but this PMD is sensible and I don't want to have a risk of making it worst in release 2.0.