From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix make defconfig on FreeBSD
Date: Mon, 23 Apr 2018 01:36:08 +0200 [thread overview]
Message-ID: <2360559.u8KFuLjH65@xps> (raw)
In-Reply-To: <20180410154440.9723-1-david.hunt@intel.com>
10/04/2018 17:44, David Hunt:
> On FreeBSD, make defconfig generates the config as "defconfig_x86_64-bsdapp-",
> which does not resolve to any known config file.
>
> This fix starts by introducing a 'compiler' variable which is set by executing
> "${CC} --version" and pulling out the name of the compiler.
[...]
> +compiler:=$(filter clang gcc icc cc,$(shell ${CC} --version))
You should not invoke a shell command outside of a rule.
Please try to move it inside the defconfig context.
Reason for this query?
1/ avoid polluting the rest of the makefile
2/ it breaks doc compilation
Why it breaks doc?
Because it breaks "make -R showversion" which is called in doc/guides/conf.py.
Tip: CC is not always defined :)
next prev parent reply other threads:[~2018-04-22 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 15:08 [dpdk-dev] [PATCH v1] " David Hunt
2018-04-10 15:28 ` Thomas Monjalon
2018-04-10 15:52 ` Hunt, David
2018-04-10 15:30 ` Burakov, Anatoly
2018-04-10 15:44 ` [dpdk-dev] [PATCH v2] " David Hunt
2018-04-10 15:55 ` Burakov, Anatoly
2018-04-22 23:36 ` Thomas Monjalon [this message]
2018-04-23 13:09 ` [dpdk-dev] [PATCH v3] " David Hunt
2018-04-23 20:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2360559.u8KFuLjH65@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).