From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 829D21DBB for ; Mon, 23 Apr 2018 01:36:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DDE1921B7E; Sun, 22 Apr 2018 19:36:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 19:36:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=z2ITmvbxB/r3UjajLz3Yf/6WeU EvYyhX4YYTBQXCd4M=; b=CGhhraQJsIvGfdKEVXHVEn34lgImqdF8PY6BluTnkS TB4UScL4NHcl0C8l7sL2YO7FvNPyPpzrqbZ4SC0M/BsXAH7ITXWj6qR68lXsbbs+ gBZlP2ZZcXAI6ZuKZ6wZxzGFgSsjwG7nNjRLFxJO8ip29GYjBfqfU6dGpdLXvBQ8 s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=z2ITmv bxB/r3UjajLz3Yf/6WeUEvYyhX4YYTBQXCd4M=; b=l46jdcIuq46m88De0++x/r rdYjaJgBp82DIRxCnjU9tw1HLoZRrnXBsL839aDo0OIc4tqFlLv1a8LWPKXWffFs wxmA7RlmrnAFtP0sV8UZL8tl+WO/gPAjy8/63IGCWkRLFt24qQVRddBKAf0wh41V FKxBJXM+76WFPoFHzuctCbxDBs78Zs6mt3vK8Wyx6Nqa2b+4i95aJhTsrQLTVvzN qpaDza+5I0GgMteHa7d1bhXeBL/mlhja2cVJHfwc38hL2JzwlNcWm1K0fQ5ZhhaX +HVHof1YuFwdAVGpXJaWdd/VwbW9LhAUiGfbmmcGo/WxjCFzTjj9rdNx+NUMd19g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 48154E5083; Sun, 22 Apr 2018 19:36:09 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, anatoly.burakov@intel.com Date: Mon, 23 Apr 2018 01:36:08 +0200 Message-ID: <2360559.u8KFuLjH65@xps> In-Reply-To: <20180410154440.9723-1-david.hunt@intel.com> References: <20180410150804.8774-1-david.hunt@intel.com> <20180410154440.9723-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mk: fix make defconfig on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 23:36:10 -0000 10/04/2018 17:44, David Hunt: > On FreeBSD, make defconfig generates the config as "defconfig_x86_64-bsdapp-", > which does not resolve to any known config file. > > This fix starts by introducing a 'compiler' variable which is set by executing > "${CC} --version" and pulling out the name of the compiler. [...] > +compiler:=$(filter clang gcc icc cc,$(shell ${CC} --version)) You should not invoke a shell command outside of a rule. Please try to move it inside the defconfig context. Reason for this query? 1/ avoid polluting the rest of the makefile 2/ it breaks doc compilation Why it breaks doc? Because it breaks "make -R showversion" which is called in doc/guides/conf.py. Tip: CC is not always defined :)