DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] igb_uio: don't bind vmxnet3 and virtio devices if disabled
@ 2014-03-05 15:16 David Marchand
  2014-03-21 10:36 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2014-03-05 15:16 UTC (permalink / raw)
  To: dev

When not using vmxnet3-uio and virtio-uio PMDs, prevent igb_uio from binding
these devices. This way, vmxnet3 and virtio PMDs won't fail to initialize
because of a device silently bound to igb_uio.

Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 lib/librte_eal/linuxapp/igb_uio/igb_uio.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
index 1c88aa8..209d61e 100644
--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -79,8 +79,12 @@ static struct pci_device_id igbuio_pci_ids[] = {
 #define RTE_PCI_DEV_ID_DECL_IGBVF(vend, dev) {PCI_DEVICE(vend, dev)},
 #define RTE_PCI_DEV_ID_DECL_IXGBE(vend, dev) {PCI_DEVICE(vend, dev)},
 #define RTE_PCI_DEV_ID_DECL_IXGBEVF(vend, dev) {PCI_DEVICE(vend, dev)},
+#ifdef RTE_LIBRTE_VIRTIO_PMD
 #define RTE_PCI_DEV_ID_DECL_VIRTIO(vend, dev) {PCI_DEVICE(vend, dev)},
+#endif
+#ifdef RTE_LIBRTE_VMXNET3_PMD
 #define RTE_PCI_DEV_ID_DECL_VMXNET3(vend, dev) {PCI_DEVICE(vend, dev)},
+#endif
 #include <rte_pci_dev_ids.h>
 { 0, },
 };
-- 
1.7.10.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] igb_uio: don't bind vmxnet3 and virtio devices if disabled
  2014-03-05 15:16 [dpdk-dev] [PATCH] igb_uio: don't bind vmxnet3 and virtio devices if disabled David Marchand
@ 2014-03-21 10:36 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2014-03-21 10:36 UTC (permalink / raw)
  To: David Marchand; +Cc: dev

05/03/2014 16:16, David Marchand :
> When not using vmxnet3-uio and virtio-uio PMDs, prevent igb_uio from binding
> these devices. This way, vmxnet3 and virtio PMDs won't fail to initialize
> because of a device silently bound to igb_uio.
> 
> Signed-off-by: David Marchand <david.marchand@6wind.com>

Acked and applied for version 1.6.0r2.

Thank you
-- 
Thomas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-21 10:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-05 15:16 [dpdk-dev] [PATCH] igb_uio: don't bind vmxnet3 and virtio devices if disabled David Marchand
2014-03-21 10:36 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).