From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by dpdk.org (Postfix) with ESMTP id 8C9A15948 for ; Fri, 18 Apr 2014 00:26:57 +0200 (CEST) Received: by mail-we0-f173.google.com with SMTP id w61so1009024wes.32 for ; Thu, 17 Apr 2014 15:26:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/LyQ65ojPaK1mVKUruKnqwHeGLAam88y+xJA943OCn0=; b=PZ2npn+YKRD0TpoJe/XerKuotIM8HaYesYAJzWmnr7k6rIjYn7MKxrT+EMEj2e8+Hx 6x06lNNV6Big7Id+d3S7+QaFH1tz9SPV65cqY9wMKeiuGamI/I86BwkiMzMwJBTa7SZO pAfZpDdsyICUGBTMza8FiQbLNNa0Fx6lfAZGFMrf3+3ClPX5VNOarbQVnl2mEJ80AOMP 6rJVh77IolYfiQxzw7vyfbui56kC4MRqrw7xLEv9Sy1kmB8FfOCECO78RToaY/ubzIro 3AqSGrLTyG5IagoIDP7/MNCaO/EaNk87ba2zSUBDKKCuTSopp3iIZPeja/iWWFG0pPfZ U8IA== X-Gm-Message-State: ALoCoQnlM0oCw6oibKAdA2c5T5LBiY82dlDnESTHM/wqikvncUuDhmkK+4d1f5b2x5Qg4muejTQ7 X-Received: by 10.180.75.45 with SMTP id z13mr14108350wiv.41.1397773618240; Thu, 17 Apr 2014 15:26:58 -0700 (PDT) Received: from xps13.localnet (abo-213-55-68.mts.modulonet.fr. [85.68.55.213]) by mx.google.com with ESMTPSA id uc3sm7280556wib.10.2014.04.17.15.26.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Apr 2014 15:26:57 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Date: Fri, 18 Apr 2014 00:26:56 +0200 Message-ID: <2364421.nEfYD68tnk@xps13> Organization: 6WIND User-Agent: KMail/4.12.4 (Linux/3.14.1-1-ARCH; KDE/4.12.4; x86_64; ; ) In-Reply-To: <1397645440-14813-1-git-send-email-nhorman@tuxdriver.com> References: <1397645440-14813-1-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: check error conditinos for every loop iteration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Apr 2014 22:26:57 -0000 2014-04-16 06:50, Neil Horman: > The return code for rte_cpu_get_flag_enabled is only checked on the > termination of the for loop that it is called inside, but should be checked > for every iteration it makes through the for loop. This is caused by some > silly missing brackets. Simply add them in > > Signed-off-by: Neil Horman > Reported-by: Pablo De Lara Guarch Acked-by: Thomas Monjalon It's applied for version 1.6.0r2. Title is changed: "eal: fix check of all requested CPU features" Thanks to all for reporting and fixing. -- Thomas