From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id A45568DB1
 for <dev@dpdk.org>; Fri, 13 May 2016 17:49:55 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id g17so37086402wme.1
 for <dev@dpdk.org>; Fri, 13 May 2016 08:49:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=+3s7QeiL+14NAuyvuWFZAot1EzCHL32eq/9//zFaxLU=;
 b=SMlcGbhzLJUqm6r5Ng8Bkg6aoOgFtYbsp3Fyo7hkYgT1e2LHPPwRkvZDYxOqCZQ/hd
 gXJcfx3M7JR2E/258zRxwkoVi/aDeQkyTqq+8RPQLMFgJiaxg/a80zA15/TY2k642Cjz
 AWNe1RNHrJhz/9SbMs/aSvpJFhthCAVYpdIynaJOPeWC6yTxW385OcfSSiEXny76eCsX
 0Maa1kbWyKReKZyboGbJhtxpNXViRbA8FRcZUoS7rwzH1luOvPnPcoDjca9215JuM5DF
 Xq9MoCXiL10/ea8TGZu1cfPqMWpyDCtCNyjdVg31etzi4ZQsfOs+cL6JJiw+4RRXCgSM
 7AHQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=+3s7QeiL+14NAuyvuWFZAot1EzCHL32eq/9//zFaxLU=;
 b=iSFjz1mNL+8/E5il7VXxx5UaZYhwBAhAuY7FSxh2ZBBUGypipt/6usTIvGDYzFM8MK
 yOp+JzLwXuZUceaMNsrOCuogawxQS4u0cBt5wUkfnHNwwBGRJNCvGsGZzWtHP153LhSh
 S9cgcdxHLqWsDtkHHUVNGPrBDMyxm/l2vpSCdFC7FI8qTF2y7+kmaMr2mQtt6oZsOrYu
 jQElLWPMxWkOCe535Ehzyor0b9BA9pzktgKsBHjF1zIOimFmNIb5mIEOY9CyS7GofvEQ
 Jfw5ZBVxTmVyxb7GiMwXI5OYqOfwG6LD+3+4jTeXnztUmBPAM3E9LdQWxJGHlctVAnMq
 4sYg==
X-Gm-Message-State: AOPr4FXGfBGwfAUhjNdOb3YyfpDMS7ndnfHk0X9qV/jZ2xaYkdwTnzkik/4VWgCnf6ZfQ1ye
X-Received: by 10.28.102.8 with SMTP id a8mr4568098wmc.54.1463154595467;
 Fri, 13 May 2016 08:49:55 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id jd4sm19188821wjb.43.2016.05.13.08.49.54
 (version=TLSv1/SSLv3 cipher=OTHER);
 Fri, 13 May 2016 08:49:54 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jianbo Liu <jianbo.liu@linaro.org>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com
Date: Fri, 13 May 2016 17:49:53 +0200
Message-ID: <2364439.Jm7BSl6O9C@xps13>
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1462869064-9423-1-git-send-email-jianbo.liu@linaro.org>
References: <1462869064-9423-1-git-send-email-jianbo.liu@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] arm64: change rte_memcpy to inline function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 May 2016 15:49:55 -0000

2016-05-10 14:01, Jianbo Liu:
> Other APP may call rte_memcpy by function pointer,
> so change it to an inline function.

Any example in mind?

> --- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h
> -#define rte_memcpy(d, s, n)	memcpy((d), (s), (n))
> +static inline void *
> +rte_memcpy(void *dst, const void *src, size_t n)
> +{
> +	return memcpy(dst, src, n);
> +}

It has no sense if other archs (arm32, ppc64, tile) are not updated.