From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CA3EA04DB; Tue, 17 Nov 2020 08:49:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98F8337B1; Tue, 17 Nov 2020 08:49:54 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 2A0A837B0 for ; Tue, 17 Nov 2020 08:49:52 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 6B2DB5801A9; Tue, 17 Nov 2020 02:49:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 17 Nov 2020 02:49:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= YndXQu8jsLXmghdBzT6n1G3aCdVFsQxdg8BI7YGAiB8=; b=mpBZvT/ZXA2n8buj nQFuxO7Oa3Np12yjP5Bz9XCFnl310u5IQXOc+w0qTnd5i1qVOTGdE+XBU8dD/WEb gKYxM6tqGhJ+lmaVt2Ce3QbO0AVuQIqw9tVt+Vvvy1JY9EV2nUtuk5bpbp3Cno5a R6QBRmeHFT6EN2OomkXhwe7HZXi0n5+PkinsCyFQqjhr6Az0PkaikEybnosseW0n /r31DwIDqSyJOoXGt/gyA9z7RNMCfw9rzC0SbEsjrx0Uh2p4APWFSkpT3mV4W66h aIcvpzSBb746UR/2mAwz5pGUt3hiQ4LzKTdAkxWuDngQ5l6S7KK6X84SIlMuMFUK uwuCXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=YndXQu8jsLXmghdBzT6n1G3aCdVFsQxdg8BI7YGAi B8=; b=k0ZpuCLgRttEjHTbJxn0yJxKC+aDUo03ULo33/BBU4QijzcktZ8qRnveb bxDf37xkeYf+bWeXWM/w6/oMLzjQOW9bcBff5tsO5IlBgZ55BktEtzGrfWGnKpLU QFuNiQTfobofn24U+e2bJTDNq86o4dxAvxNKgJS8uQArD4eqJfyKbA8HSHb2V5B5 pIHjmKnz0Ydbq0wDu8X2b52/uh5sPpxdgvBMH8CW+iGEAgsXfMoADOjmfRMqCrgN 4K9ZuFGfsszushFdeu7tk0BYEnQVmyWgKqz/ZnlhkpWjxAbo9Mnem19gWgmr0Je1 71ROfRbm+W9jqokeHuIX1z1aHoR0A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefvddguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeffiefftdetkeehhfdvgedvgfelfeevffdtkefgfeejhfeltdei veduleejjeehjeenucffohhmrghinhepthigthdrihhtpdgtohhmphgrthhisghilhhith ihrdhsohenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DD3923280068; Tue, 17 Nov 2020 02:49:48 -0500 (EST) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= , Bruce Richardson , Honnappa Nagarahalli Cc: Ruifeng Wang , Phil Yang , "vcchunga@amazon.com" , Dharmik Thakkar , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , "ferruh.yigit@intel.com" , "dev@dpdk.org" , "david.marchand@redhat.com" , nd Date: Tue, 17 Nov 2020 08:49:45 +0100 Message-ID: <2366611.vJsMBebm0t@thomas> In-Reply-To: References: <1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech> <4553269.LkjHWWX2LK@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v12 01/14] build: alias default build as generic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/11/2020 03:46, Honnappa Nagarahalli: > >=20 > >=20 > > 16/11/2020 17:16, Bruce Richardson: > > > On Mon, Nov 16, 2020 at 03:50:31PM +0000, Juraj Linke=C5=A1 wrote: > > > > From: Thomas Monjalon > > > > > 13/11/2020 15:31, Juraj Linke=C5=A1: > > > > > > The current machine=3D'default' build name is not descriptive. = The > > > > > > actual default build is machine=3D'native'. Add an alternative > > > > > > string which does the same build and better describes what we're > > building: > > > > > > machine=3D'generic'. Leave machine=3D'default' for backwards > > compatibility. > > > > > > > > > > What? > > > > > > > > > > "generic" means... nothing. > > > > > > > > > > > > > An absence of anything means nothing. Generic means "characteristic= of > > or relating to a class or group of things; not specific", which is pret= ty much > > what we're looking for. > > > > > > > > > "default" should be the most common set of options to make a build > > > > > work everywhere. > > > > > > > > What we want is a value of machine that would "be the most common > > set of options to make a build work everywhere" and using the above > > definition of generic, it fits very well. > > > > The reason I said the actual default build is machine=3D'native' is= because > > that's how the machine option is defined in meson_options.txt. It follo= ws > > from what default actually means - "a preselected option adopted by a > > computer program or other mechanism when no alternative is specified by > > the user or programmer". Default then means no user input, which means > > machine=3D'native', which means the default build is the default build. > > > > > > > > What ""default" should mean" looks like an attempt at redefining wh= at > > the word actually means and leads to confusion, in my experience. Hence= an > > attempt to remove the potential ambiguity. > > > > > > > > > > I would tend to agree that "generic" is probably a better term than > > > "default" for what we use it for here in the config. > >=20 > > In the past, we had a different definition with make config. > > I am just trying to be consistent. > > Even with meson, default means "minimal CPU instructions". > >=20 > > Example in devtools/test-meson-builds.sh: > > "test compilation with minimal x86 instruction set" > > is called build-x86-default. > >=20 > > In config/meson.build: > > " > > machine type 'default' is special, it defaults to the per arch agreed c= ommon > > minimal baseline needed for DPDK. > > That might not be the most optimized, but the most portable version whi= le > > still being able to support the CPU features required for DPDK. > > This can be bumped up by the DPDK project, but it can never be an invar= iant > > like 'native' > > " > >=20 > > So, why this definition is called "generic" in meson Arm config? > The explanation above is for a build type 'default'. Whereas meson by def= ault builds for build type 'native'. Also when you look at the config/arm/m= eson.build the word 'default' was used where it was not related to the buil= d type default. It created lot of confusion. >=20 > From the dictionary 'default' - "a preselected option adopted by a comput= er program or other mechanism when no alternative is specified by the user = or programmer." But, if one had to do build of type default, they have to m= ention -Dmachine=3Ddefault. If nothing is mentioned, it is a build type 'na= tive', which does not go along with the definition of 'default'. >=20 > But for 'generic' - "characteristic of or relating to a class or group of= things; not specific". IMO, it better suits the explanation you have provi= ded above. So, separating this machine type to 'generic' to cover the same = definition makes more sense. >=20 > However, 'default' is still supported for backward compatibility. So? Are you going to change the DPDK definitions we had for years?