From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f173.google.com (mail-wj0-f173.google.com [209.85.210.173]) by dpdk.org (Postfix) with ESMTP id A5E3832A5 for ; Wed, 7 Dec 2016 09:38:12 +0100 (CET) Received: by mail-wj0-f173.google.com with SMTP id tg4so97948362wjb.1 for ; Wed, 07 Dec 2016 00:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=cyy8cevGqP+NHmK5aB43hhgs6CttQUO84vOZbfu+bZ4=; b=U3QefQMzZ/xQpkfkcZ8ALN+YyD2cvDpR13WGpxMH+FijxYDwBErzgW2t6G+8Ph8/q2 Wb4Z3c/k854rbKxiVwglAFTVCq3PVEb0/70DVfI+FD13D2bqyit3Mnin/iE0htdxfiXg EQckiuho7r1y3nST2faGq0R0QHxJWNXm+hPjWNjyufLM1geqbQiZ70XhziigeVmSwKJH SQ6Ia9NhIqEfVmIKyZP+lZCfmIiSf/FTwMO8/zQA3U5CrqSAErKaCy7PHlLyrIN8MPoV ZYvpmBnrj1USs8v96EsE29C6OgOaMwJBjweZo8+h325ygiRrDBYP9ZMM0qQeWRwkezd2 4Eeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=cyy8cevGqP+NHmK5aB43hhgs6CttQUO84vOZbfu+bZ4=; b=Il2yIYUkCLq+eQr0w7jTgGP+L0kyXYjBSVMmAuWY+dNrsswc8cHX/ahgkpNyBAkJXh h2M01AadUZJVx9ttO4L6ybiBqKm7XEQ9tSKEvslR4FW+3SH61e07wxkv4EiKKg+y31ee zZAHl+F+I9jYWee26MpfhWxvW0Z4SMpSWdltAZMoTsx2RGH9Mq9euhxWOFXdSKvWs5jC koZE+4jG1FcDiyaLuD9X6SVc0BtcpY7KkRaS5Ccuw6lOmTTFzOiXqaEMSZzRk2Sh5T3a VcvRnpmjWzvvVIUzuxhgF2BELFIRfnppFRA8gM2dq77ZWeLmnf2/CE5R0HtdahOtI/6U b5Fg== X-Gm-Message-State: AKaTC00u0lkIXjjlwCWeXGKCYF6UPgWLVP49m40e1P3binqvedj3xXuBPP/ULhPsTnrGZHod X-Received: by 10.194.57.9 with SMTP id e9mr55217553wjq.116.1481099892382; Wed, 07 Dec 2016 00:38:12 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 197sm8335031wmy.16.2016.12.07.00.38.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2016 00:38:11 -0800 (PST) From: Thomas Monjalon To: Hemant Agrawal Cc: dev@dpdk.org, bruce.richardson@intel.com, shreyansh.jain@nxp.com Date: Wed, 07 Dec 2016 09:38:10 +0100 Message-ID: <2366721.OpDVYN8WCp@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <4516168.6vIN5TbTdY@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 11/32] net/dpaa2: add dpaa2 vfio support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 08:38:12 -0000 2016-12-07 12:30, Hemant Agrawal: > On 12/7/2016 2:34 AM, Thomas Monjalon wrote: > > 2016-12-04 23:47, Hemant Agrawal: > >> Add support for using VFIO for dpaa2 based fsl-mc bus. > > > > Why do we need so much special code for interfacing VFIO on fsl-mc? > > Can you reuse some code from EAL VFIO? > > > > fsl-mc VFIO scans the objects. So, it is slightly different. > > Even though I have tried to minimize changes and re-use the code from > EAL VFIO. It is still refactoring work, which we will take up little later. Do you mean you could re-use some EAL code but do not want to do it now? It sounds like something heard too many times earlier (from others). The experience tells we must not wait to do things right.