From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 3B2752C29 for ; Wed, 3 Aug 2016 18:44:17 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id i5so344861089wmg.0 for ; Wed, 03 Aug 2016 09:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=j4PHKAn6KOJHXNttGudQHmeDkfVq9xCysajDXpYMVoI=; b=N9pA2vFlclhBSaTcuUX0NfurU2gh/C575qJQtZYuDWp+Lm/0OSktPsPZ7gWFPvwhvV lS/sulf/AylgtIrHOKPjHEJ8AwVz2txI3iMk97tlbd0nVLBZZEIXvXZ23Kh2GmzsHA0R hMU+9a8acCJ6Itwa1EMcJ5A06n/PDvuv3AvuaVSdo3k91/N2PC6V4i+ORONUkvEXluZv UfX903Qya0LiiswQ1eRUHgQ8gCiwlgy80BYrKdQta5G2BdxvJ05qYTeA7M/usslL7zez GyEqBaDrKBgddMyN0WdgIaYNfLFPulENOIrDP8XQwDGjMq8iaceaWgcW0y0oAJLx++6D 8zXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=j4PHKAn6KOJHXNttGudQHmeDkfVq9xCysajDXpYMVoI=; b=K8f1bKzLr//m+dpSNWSFW1m1k+nskTC35ldT/Iqy2hn+iuCI1roId55MSc9XuJwaqC RYPPMLQ/IpGsDaemTO50EDFydoBydOvX1tjR8u3ydMYO0xjE/8595QdRiYcIUZTAqz26 DdVddEa2nw/uRGtxV8yfUi+ytZDHu+VbZj2C5bnhlnCdPgtkR4o+RDQnp81JH2D/CkFn +kWNzdQ217nEssWxfgaDBA45hc2sNepzq55cS2USBk8hN+RhOKqi8WJYP5EJoJY8HUSc cHcPGw3KxmEo2sUzy3itoqPvevMSR+EtOrkvD8mp+UAlmTeXhxw4L2dtfc+EpAuclkWl cmfg== X-Gm-Message-State: AEkooutXrfXXveuIYj+PLsoKz8BsWape5DeOnmHXBQ5D3br3hlNBzxJxK4Dkj8BLyIwBlqVw X-Received: by 10.194.148.81 with SMTP id tq17mr61388721wjb.67.1470242656907; Wed, 03 Aug 2016 09:44:16 -0700 (PDT) Received: from xps13.localnet (86.114.118.80.rev.sfr.net. [80.118.114.86]) by smtp.gmail.com with ESMTPSA id bj8sm8507369wjc.49.2016.08.03.09.44.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Aug 2016 09:44:16 -0700 (PDT) From: Thomas Monjalon To: John McNamara Cc: Bruce Richardson , dev@dpdk.org Date: Wed, 03 Aug 2016 18:44:15 +0200 Message-ID: <2367246.tp1XcRvkfJ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160803143222.GA13564@bricha3-MOBL3> References: <1467309817-11739-1-git-send-email-john.mcnamara@intel.com> <3844504.Omypy6q39V@xps13> <20160803143222.GA13564@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] doc: autogenerate nic overview table from ini files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2016 16:44:17 -0000 2016-08-03 15:32, Bruce Richardson: > On Mon, Aug 01, 2016 at 11:37:03PM +0200, Thomas Monjalon wrote: > > Hi John, > > > > 2016-07-29 12:59, John McNamara: > > > Convert the NIC feature table in the overview doc into a set of ini > > > files and add functions into the Sphinx conf.py file to auto-generate > > > them back into an RST table. > > > > I have not reviewed the Python code which generate the RST table. > > It works so it could be applied as is. > > > > > The reason for doing this is to make it easier for PMD maintainers to > > > update the feature matrix that makes up the table and to avoid > > > frequent and hard to resolve conflicts in doc/guides/nics/overview.rst. > > > > Yes thanks for the work. > > > > My main concern before applying this patch, is the name of the files: > > > > > doc/guides/nics/nic_features/fm10k.ini | 34 ++++++ > > > doc/guides/nics/nic_features/fm10k_vec.ini | 34 ++++++ > > > doc/guides/nics/nic_features/fm10k_vf.ini | 28 +++++ > > > doc/guides/nics/nic_features/fm10kvf_vec.ini | 28 +++++ > > > doc/guides/nics/nic_features/i40e.ini | 47 ++++++++ > > > doc/guides/nics/nic_features/i40e_vec.ini | 39 +++++++ > > > doc/guides/nics/nic_features/i40e_vf.ini | 36 +++++++ > > > doc/guides/nics/nic_features/i40evf_vec.ini | 28 +++++ > > > doc/guides/nics/nic_features/igb.ini | 44 ++++++++ > > > doc/guides/nics/nic_features/igb_vf.ini | 27 +++++ > > > doc/guides/nics/nic_features/ixgbe.ini | 54 ++++++++++ > > > doc/guides/nics/nic_features/ixgbe_vec.ini | 46 ++++++++ > > > doc/guides/nics/nic_features/ixgbe_vf.ini | 37 +++++++ > > > doc/guides/nics/nic_features/ixgbevf_vec.ini | 29 +++++ > > > > It would be more consistent to always put an underscore before vf. > > > > About the directory, I suggest doc/guides/nics/features/. > > > > Other small nit: there is a typo in every files: availble -> available. > > > > It would be nice to start the 16.11 cycle with this change and make sure we > > won't change the filenames later in the cycle. So we can start sending > > some patches without risking a conflict. > > Thanks > > Those changes you propose seem reasonable to me. Having this table as ini files > will be a big help in reducing merge conflicts! As John is not available for some days, I've decided to make the above suggested changes. Applied, thanks