From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6] af_packet: Fix some klocwork errors
Date: Tue, 10 Mar 2015 11:19:46 +0100 [thread overview]
Message-ID: <2369370.HKrG2BAiBe@xps13> (raw)
In-Reply-To: <F52918179C57134FAEC9EA62FA2F962511A2FF15@shsmsx102.ccr.corp.intel.com>
2015-03-10 08:49, Ouyang, Changchun:
> From: Wodkowski, PawelX
> > > + if (kvlist != NULL)
> >
> > No need for if(). This part was fine previous patch.
> >
>
> If kvlist is NULL, no reason to call rte_kvargs_free to free it.
> So, adding this test is better.
No, we don't need to double check.
1/ it's already checked in rte_kvargs_free()
2/ less lines you write, better it is
> > > + rte_kvargs_free(kvlist);
> > > + return ret;
> > > }
next prev parent reply other threads:[~2015-03-10 10:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 6:42 [dpdk-dev] [PATCH] " Ouyang Changchun
2015-02-26 8:44 ` Pawel Wodkowski
2015-02-27 0:49 ` [dpdk-dev] [PATCH v2] " Ouyang Changchun
2015-02-27 14:04 ` Neil Horman
2015-02-28 0:51 ` Ouyang, Changchun
2015-02-28 1:27 ` [dpdk-dev] [PATCH v3] " Ouyang Changchun
2015-03-09 3:49 ` [dpdk-dev] [PATCH v4] " Ouyang Changchun
2015-03-09 6:38 ` Qiu, Michael
2015-03-09 8:47 ` Ouyang, Changchun
2015-03-09 8:58 ` [dpdk-dev] [PATCH v5] " Ouyang Changchun
2015-03-09 19:25 ` John W. Linville
2015-03-10 3:29 ` [dpdk-dev] [PATCH v6] " Ouyang Changchun
2015-03-10 8:36 ` Pawel Wodkowski
2015-03-10 8:49 ` Ouyang, Changchun
2015-03-10 8:59 ` Pawel Wodkowski
2015-03-10 10:19 ` Thomas Monjalon [this message]
2015-03-11 1:18 ` Ouyang, Changchun
2015-03-11 1:34 ` [dpdk-dev] [PATCH v7] " Ouyang Changchun
2015-03-12 10:43 ` Qiu, Michael
2015-03-12 13:38 ` Neil Horman
2015-03-12 17:09 ` John W. Linville
2015-03-17 21:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2369370.HKrG2BAiBe@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).