From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FDD6A0A0E; Wed, 28 Apr 2021 13:13:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9C2D410E0; Wed, 28 Apr 2021 13:13:39 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 877E340147 for ; Wed, 28 Apr 2021 13:13:37 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EB1625C010E; Wed, 28 Apr 2021 07:13:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 28 Apr 2021 07:13:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= RRkTN1aubzDRqldUBoX4dsk6ZB2lC/9bVXHZIMjbrsQ=; b=XR6QAXyZajDCBTd8 BcjpUkazkzajdtOwKm1h5EfVxsfq+PB8KUY0YzQd9Ni5r7AeLcIQUrs+VRyZPYEB m/mnjqjLPew8ADhWoUeTo/Mh2Wnn4OC91C+Ut8Vv5rZBuSqD9g7dgFalLqaFqiqh BOaqtuxskqDZyoWsNQls3HJL6cNVgyAGEPYEg5qoxd2bP54drhTWESrhPooACtWt rl83JIsT0Wu8gHfwO8UiSlvtXBH62nwVHQXnMJhrsQ4T/mh0geYv/Ij4H0qs8Nj4 y8wiXiZvXf8UagGtMfgeBFLnvAMf9Gedll6A/mOmLZbutlfrcN79kfqtXT1fCsoU bT1SQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=RRkTN1aubzDRqldUBoX4dsk6ZB2lC/9bVXHZIMjbr sQ=; b=paYHpbEFsLpIIfTP7tHKiD0/BN3RJNOFFhmse0SfukMRIIIrfpOKuKSmQ roaxIHoZtsIDHU/9hBFEHpO1h+dz3E5qFstriIHQ3pezeUKfhuOIbq1TddZMWTtK iupzRInQChYpsY+av1jEvjJliZrgNI/NPp+yRPpWL0am0F1CS2bwMkmIg1l86KqJ AvkeTBUeWpA0k16wkD37P2mS2PaLaKw6zTX9a5llTV1GZC47FUwSIUsimCK2DVtG bU1J4KhR7tuNjyvAGrqw1wOm2OB7QZbhuHpx+wSo1Gk3iGFMXe+GKImIYrZpez/K w9zDC8tv9+zgsDAWprrabhtL/BMhQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvvddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 28 Apr 2021 07:13:34 -0400 (EDT) From: Thomas Monjalon To: Ruifeng Wang Cc: David Marchand , dev , "jerinj@marvell.com" , nd , Honnappa Nagarahalli Date: Wed, 28 Apr 2021 13:13:33 +0200 Message-ID: <2370044.79WzprfWfc@thomas> In-Reply-To: References: <20200424070741.16619-1-gavin.hu@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Use WFE for spinlock and ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/04/2021 11:30, Ruifeng Wang: > From: David Marchand > > On Sun, Apr 25, 2021 at 7:57 AM Ruifeng Wang > > wrote: > > > > > > The rte_wait_until_equal_xxx APIs abstract the functionality of > > > 'polling for a memory location to become equal to a given value'[1]. > > > > > > Use the API for the rte spinlock and ring implementations. > > > With the wait until equal APIs being stable, changes will not impact ABI. > > > > Afaics, there is no ARM target with WFE enabled and we lost ability to enable > > WFE support with removal of the make build system. > > WFE can be enabled with direct meson file change. > WFE is not intended to be enabled by default. It can be enabled based on benchmarking > result on hardware. > > > > $ git grep RTE_ARM_USE_WFE > > config/arm/meson.build: ['RTE_ARM_USE_WFE', false], > > lib/eal/arm/include/rte_pause_64.h:#ifdef RTE_ARM_USE_WFE > > > > How did you enable WFE to test this series? > > I modified meson file to test. > Tests were also done with WFE disabled to make sure no degradation with generic implementation. I don't understand the usage. Which platform should use it? Should it be a compile-time option?