From: Thomas Monjalon <thomas@monjalon.net>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, vipin.varghese@intel.com
Subject: Re: [dpdk-dev] [PATCH] eal/service: improve error checking of coremasks
Date: Tue, 15 May 2018 17:38:01 +0200 [thread overview]
Message-ID: <2371860.oF3rqsruhg@xps> (raw)
In-Reply-To: <1526395965-133647-1-git-send-email-harry.van.haaren@intel.com>
15/05/2018 16:52, Harry van Haaren:
> + if (eal_service_cores_parsed())
> + RTE_LOG(ERR, EAL,
> + "Warning: Service cores parsed before dataplane cores. Ensure -c is before -s or -S.\n");
> +
[...]
> + if (core_parsed && taken_lcore_count != count) {
> + RTE_LOG(ERR, EAL,
> + "Warning: not all service cores were in the coremask - ensure -c or -l includes service cores\n");
> + }
Sometimes, messages are split with a dot, sometimes with a dash.
Please choose only one for consistency (I prefer dot).
I think you can split the string and wrap the line at the end of the sentence.
next prev parent reply other threads:[~2018-05-15 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 14:52 Harry van Haaren
2018-05-15 15:38 ` Thomas Monjalon [this message]
2018-05-15 15:56 ` [dpdk-dev] [PATCH v2] " Harry van Haaren
2018-05-21 9:41 ` Varghese, Vipin
2018-07-12 7:35 ` Thomas Monjalon
2018-07-13 17:27 ` Van Haaren, Harry
2018-07-13 17:25 ` [dpdk-dev] [PATCH v3] " Harry van Haaren
2018-07-13 17:33 ` Thomas Monjalon
2018-07-26 14:18 ` Thomas Monjalon
2018-07-13 17:45 ` Varghese, Vipin
2018-07-26 16:16 ` [dpdk-dev] [PATCH v4] " Harry van Haaren
2018-07-26 16:31 ` [dpdk-dev] [PATCH v5] " Harry van Haaren
2018-07-26 16:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2371860.oF3rqsruhg@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).