DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: remove l3_l4_xsum_errors from rx errors
Date: Wed, 04 Nov 2015 17:57:17 +0100	[thread overview]
Message-ID: <23734920.erH16WLlfy@xps13> (raw)
In-Reply-To: <1446653683-10407-1-git-send-email-harry.van.haaren@intel.com>

2015-11-04 16:14, Harry van Haaren:
> This patch removes l3_l4_xsum_errors from rx errors.
> 
> The reason to remove it is that UDP packets have an optional checksum, and
> when not calculated the checksum field should be set to zero. When the
> checksum is not calculated (zero-ed out), the hardware still counts a valid
> UDP packet as an l3_l4_xsum_error.
> 
> This hardware issue is documented in 82599 errata, titled:
> "Integrity Error Reported for IPv4/UDP Packets with Zero Checksum"
> 
> The solution is to remove l3_l4_xsum_errors from rx_errors, as discussed on
> http://thread.gmane.org/gmane.comp.networking.dpdk.devel/25590/
> 
> Fixes: f6bf669b9900 ("ixgbe: account more Rx errors")
> 
> Suggested-by: Martin Weiser <martin.weiser@allegro-packets.com>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks

      reply	other threads:[~2015-11-04 16:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21  8:38 [dpdk-dev] ixgbe: ierrors counter spuriously increasing in DPDK 2.1 Martin Weiser
2015-10-21 15:53 ` Andriy Berestovskyy
2015-10-22  7:46   ` Martin Weiser
2015-10-22 10:56     ` Andriy Berestovskyy
2015-11-02 17:32 ` Van Haaren, Harry
2015-11-04  9:10   ` Martin Weiser
2015-11-04 15:50     ` [dpdk-dev] [PATCH] ixgbe: remove l3_l4_xsum_errors from rx errors Harry van Haaren
2015-11-04 16:08       ` Thomas Monjalon
2015-11-04 15:54     ` [dpdk-dev] ixgbe: ierrors counter spuriously increasing in DPDK 2.1 Van Haaren, Harry
2015-11-04 16:29       ` Martin Weiser
2015-11-04 16:14     ` [dpdk-dev] [PATCH v2] ixgbe: remove l3_l4_xsum_errors from rx errors Harry van Haaren
2015-11-04 16:57       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23734920.erH16WLlfy@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).