From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: HELIN ZHANG <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: bug fix of compiling KNI kernel module on Linux kernel 3.6.10
Date: Tue, 20 May 2014 11:16:05 +0200 [thread overview]
Message-ID: <23739506.Drt1PRsGzO@xps13> (raw)
In-Reply-To: <1400422458-16322-1-git-send-email-helin.zhang@intel.com>
2014-05-18 22:14, HELIN ZHANG:
> Error of "implicit-function-declaration" can be seen when building
> KNI kernel module on Linux kernel 3.6.10 platform.
Please show the error message in the commit log.
> The root cause is as follows.
> On Linux kernel 3.6.10, ETHTOOL_GEEE is defined in Linux header file
> of "linux/ethtool.h", while is not defined in most of other
> linux kernel versions.
> mmd_eee_cap_to_ethtool_sup_t(), mmd_eee_adv_to_ethtool_adv_t() and
> ethtool_adv_to_mmd_eee_adv_t() in kcompat.h are disabled by
> "#if !defined(ETHTOOL_GEEE) || (RHEL_RELEASE_CODE && RHEL_RELEASE_CODE
> <= RHEL_RELEASE_VERSION(6,4))", while are called in igb_get_eee()
> in igb_ethtool.c which is enabled by "#ifdef ETHTOOL_GEEE".
The title is about Linux 3.6.10 but is seems more related to a RedHat version.
Could you fix title and commit log, please?
Is it related to this error?
http://dpdk.org/ml/archives/dev/2014-May/002457.html
Neil made an interesting comment about it:
http://dpdk.org/ml/archives/dev/2014-May/002351.html
Thanks
--
Thomas
prev parent reply other threads:[~2014-05-20 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 14:14 HELIN ZHANG
2014-05-20 9:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23739506.Drt1PRsGzO@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).