From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 9A3132E8A for ; Tue, 20 May 2014 11:15:59 +0200 (CEST) Received: by mail-wi0-f177.google.com with SMTP id f8so554480wiw.4 for ; Tue, 20 May 2014 02:16:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=v6lwmId0YLmI44oPibJ+Y9PA29ElEnJ1kmO3yUcEEok=; b=EG3JIgwn8g9GK8hBWA70ogHOXOrk8qvHS9a2Z3A4ka77iB2auo1MdjOPBuBavjZfax 1232xh8U+azBaexGoKeqhmMMZPnajQsJarkFLZtn+JaY3U6tmvvPGc0+tVuG0fhLG73x erBq0rYgci4FOTm07YUwLtJNDNiwwSlE/arngRdEAKkiqwT8stZHcez5wr75yGPwhdvZ ove701QmEtmOMtyujw4nrxcCH1tTx3iqfFqk+9kQljMRVUb72uQ5h2rsxry+yysEqnTy qul62oKPTcQFN+WxKgq6y0YFttduXUfxQvoHKY+g8D5b2aGCe6J+fWREjojpBa1fm9GR rF5w== X-Gm-Message-State: ALoCoQlr/0rNbpQpNBMIzJvPvHddF8SRhFHjlJId/0gPw3DC7LiFowewqrWXIqmLoSBv6cA56P2c X-Received: by 10.180.186.8 with SMTP id fg8mr2730978wic.39.1400577368545; Tue, 20 May 2014 02:16:08 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id fq2sm19708867wib.2.2014.05.20.02.16.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 May 2014 02:16:07 -0700 (PDT) From: Thomas Monjalon To: HELIN ZHANG Date: Tue, 20 May 2014 11:16:05 +0200 Message-ID: <23739506.Drt1PRsGzO@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400422458-16322-1-git-send-email-helin.zhang@intel.com> References: <1400422458-16322-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] kni: bug fix of compiling KNI kernel module on Linux kernel 3.6.10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2014 09:15:59 -0000 2014-05-18 22:14, HELIN ZHANG: > Error of "implicit-function-declaration" can be seen when building > KNI kernel module on Linux kernel 3.6.10 platform. Please show the error message in the commit log. > The root cause is as follows. > On Linux kernel 3.6.10, ETHTOOL_GEEE is defined in Linux header file > of "linux/ethtool.h", while is not defined in most of other > linux kernel versions. > mmd_eee_cap_to_ethtool_sup_t(), mmd_eee_adv_to_ethtool_adv_t() and > ethtool_adv_to_mmd_eee_adv_t() in kcompat.h are disabled by > "#if !defined(ETHTOOL_GEEE) || (RHEL_RELEASE_CODE && RHEL_RELEASE_CODE > <= RHEL_RELEASE_VERSION(6,4))", while are called in igb_get_eee() > in igb_ethtool.c which is enabled by "#ifdef ETHTOOL_GEEE". The title is about Linux 3.6.10 but is seems more related to a RedHat version. Could you fix title and commit log, please? Is it related to this error? http://dpdk.org/ml/archives/dev/2014-May/002457.html Neil made an interesting comment about it: http://dpdk.org/ml/archives/dev/2014-May/002351.html Thanks -- Thomas