From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E90DAA0A0E; Wed, 3 Feb 2021 16:53:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77EF1240637; Wed, 3 Feb 2021 16:53:47 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 9DE7324062E for ; Wed, 3 Feb 2021 16:53:45 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 2D63E9F2; Wed, 3 Feb 2021 10:53:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 03 Feb 2021 10:53:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= jBMEvBYAi4WpC3d4gjvirXC13Ue8MNls3g8i8ctKizA=; b=EGyq5SSZIRAZJwQ2 k6taYX610NSNg9ETi0HllkBs7O2ostj20rn+hhPp9mcyObeiCL61+iTuO52wznbr E4KN6efkB0sF3DMZ0Wjjh4sWqyHmKXFvsS+HxNSKjaywfGqGfNSieRw+6CNFIRHw ELv0FgVtMWgRBU0WHs8uMCFoZ+J9Q8QlOWrdY2iPSQHbLQaW42ir00nD0tJIJ4R/ yM5Mc7UvtNFYqGHOZ9mXTPHc/AQnh8CRNcEYNo+jr3rvF381+makyTm5um5394Ch /K2mcS66kdzh86HoPTdnhpCnbWJLwNRaSfaMKtMUWXNv8sj0QtsIgeDzpCBWq2V7 qXwRaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=jBMEvBYAi4WpC3d4gjvirXC13Ue8MNls3g8i8ctKi zA=; b=N8OLJvCdfPp7eOxuBtQjlSw8u89IE7Z7C+obPfehRssw8m4Z2TqO67zbN pf8r90kI61m/YvkyQJyvp6rXkCatsbmhbCnfRv9CIiL4+0dZOuK7pqbFA70HFtg6 6g4iUG8/xIfQik4keNxzXnCkSitgwrQQqSDVnU971/BbS+YKVm0Fn9W/h9wFY6i5 EucPQ1PBQ91R4ZEjm40hlAIgW6BBO83Sk893Xwk8HivRFUWfclZLkDvTxoUDo+nA knujnKjPet2NF1k9lW0uOyfQtygtUOH509fxFQJo1emqC5z4+38Sd1hH69xbI6ZH ojbDU1CQ+gj7k4rtiP+q6Io/9FIfw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgedvgdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeegvdehhfevkeffgeekhfdtfeevfeejkeeugfevfeejfefhjedttefh veefteefjeenucffohhmrghinhepghhithhhuhgsuhhsvghrtghonhhtvghnthdrtghomh dpghhithhhuhgsrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmh honhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A945A108005B; Wed, 3 Feb 2021 10:53:41 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Wed, 03 Feb 2021 16:53:39 +0100 Message-ID: <2375767.y8tl029X38@thomas> In-Reply-To: <20210203135921.GB1708@bricha3-MOBL.ger.corp.intel.com> References: <20210203103057.2821352-1-thomas@monjalon.net> <107491602.YXUHrCGqlC@thomas> <20210203135921.GB1708@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] doc: explain steps for improved code spell checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/02/2021 14:59, Bruce Richardson: > On Wed, Feb 03, 2021 at 01:53:58PM +0100, Thomas Monjalon wrote: > > 03/02/2021 13:18, Bruce Richardson: > > > On Wed, Feb 03, 2021 at 11:30:57AM +0100, Thomas Monjalon wrote: > > > > - https://raw.githubusercontent.com/codespell-project/codespell/master/codespell_lib/data/dictionary.txt > > > > + git clone https://github.com/codespell-project/codespell.git > > > > > > > > > > Does installing via apt or dnf work as well? If we do install from package > > > do we still need to specify the path to codespell as script parameter? > > > > It depends whether all needed dictionary files are installed. Are they? > > > > > > -The path to the downloaded ``dictionary.txt`` must be set > > > > +There is a DPDK script to build an adjusted dictionary:: > > > > + > > > > + devtools/build-dict.sh codespell/ > codespell-dpdk.txt > > > > + > > > > > > Do we always need to have people build this themselves? Can we create a > > > .codespell-dpdk.txt file in the repo and have that as the default value for > > > the path if the environment variable is not set? > > > > The dictionaries are frequently updated. > > I don't really want to update them in DPDK. > > > > The default dictionary from the distro is used by default (if installed). > > > > In general, I think only tree maintainers and CI admins > > have to install the dictionaries for better result. > > > That's good. Perhaps it's better to note down then first that the default > distro dictionaries are used and if one wants enhanced checking to follow > the extra steps. Yes I'll reword.