DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, vipin.varghese@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks
Date: Thu, 26 Jul 2018 16:18:11 +0200	[thread overview]
Message-ID: <2376975.KA9Fdbqaqj@xps> (raw)
In-Reply-To: <2874140.BQP81VYxLs@xps>

Hi Harry,

Are you OK to make a v4?


13/07/2018 19:33, Thomas Monjalon:
> 13/07/2018 19:25, Harry van Haaren:
> > v3:
> > - Use WARNING instead of ERR log level (Vipin)
> > - Put strings on one line for grep-ability (Harry)
> 
> We can consider it is OK to have sentences on different lines.
> Who is grepping 2 sentences at once?
> 
> > v2, thanks for review:
> > - Consistency in message endings - vs . (Thomas)
> 
> Some dots are missing.
> 
> > - Wrap lines as they're very long otherwise (Thomas)
> 
> Lines are not wrapped.
> 
> > +		RTE_LOG(WARNING, EAL,
> > +			"Service cores parsed before dataplane cores Please ensure -c is before -s or -S.\n");
> 
> I think this would be better:
> 
> 		RTE_LOG(WARNING, EAL,
> 			"Service cores parsed before dataplane cores. "
> 			"Please ensure -c is before -s or -S.\n");

  reply	other threads:[~2018-07-26 14:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 14:52 [dpdk-dev] [PATCH] " Harry van Haaren
2018-05-15 15:38 ` Thomas Monjalon
2018-05-15 15:56 ` [dpdk-dev] [PATCH v2] " Harry van Haaren
2018-05-21  9:41   ` Varghese, Vipin
2018-07-12  7:35     ` Thomas Monjalon
2018-07-13 17:27       ` Van Haaren, Harry
2018-07-13 17:25   ` [dpdk-dev] [PATCH v3] " Harry van Haaren
2018-07-13 17:33     ` Thomas Monjalon
2018-07-26 14:18       ` Thomas Monjalon [this message]
2018-07-13 17:45     ` Varghese, Vipin
2018-07-26 16:16     ` [dpdk-dev] [PATCH v4] " Harry van Haaren
2018-07-26 16:31       ` [dpdk-dev] [PATCH v5] " Harry van Haaren
2018-07-26 16:40         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2376975.KA9Fdbqaqj@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).