From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 50166DE5 for ; Wed, 18 Jan 2017 00:57:32 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id r144so248552188wme.1 for ; Tue, 17 Jan 2017 15:57:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=wNh1VGI+FQ+LhcoC5wPhwXHqDpvM+3g7KLKERoabvXI=; b=GZJB5o7OR2ctbRpymv3T1TmrzEgUl8Me5hr4g26wnoutLZnNPBALTiI5Q4gidM7Yce VvgI83+gipsU6VlqaqHhV0phhkjnfKIzbPDT1nB+3wbkz8pGPBZGV5dBxIKgva0iow1+ 5H3yM8iTvi2sDd71TPtXBIQMPywpjyd4rwcGq/uX+sHJxRqx7Ad7Q7Rhyd/2wV6nkye9 xwvS+jFplyEwKIP+5SI+Oj57HF6DJX+3tTlkEE7f6uzMXaSYTihdyza1S9pQ8RyC66RT /rwAvBH3OOBi7N8YxLhmIaxlPmzIodHUs5mI+S3ggMz0yC0iaAtqIvwTNLSVy1ggqES3 m1ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=wNh1VGI+FQ+LhcoC5wPhwXHqDpvM+3g7KLKERoabvXI=; b=IuKv5BrO27ZSy0V/YaOl4m4EJPMqAkwpn+uI3TgurFAbgcFacDyeKSe3XF4R/PngOi eFCSCFQr/L6W3+oZO8/gpzeuuAvxOc0hgXR4ITuf9acDd3ZaXrbeW9HuYUm4jNBVRf5j WZdtDNu7giBtNogQt4A3d8Yff+Qnxt1uwZO2FXYClrF63z7eBL10Et8++CuoN3F2g1cN fhYWSrRsLAELX5cFSBksXSPIPSgU0EhITQorCUhTIPCFNbEvuFAa2TbH+zvM7El+YdRo keKnZ/9XfCsxbA/N5f5dg7+RwNvP77t2xE05wg+RDZaQ+qfhLzbVB06GtiGmBZMcopUl vSYQ== X-Gm-Message-State: AIkVDXKtycXbX7Vfbt+QUr5bbbJZeVgIg54w5GzpCvbRTBsH2OMZB5rJ+VEVxwC8z+bUKGst X-Received: by 10.28.63.15 with SMTP id m15mr19804976wma.119.1484697452053; Tue, 17 Jan 2017 15:57:32 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 197sm40680146wmy.16.2017.01.17.15.57.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 15:57:31 -0800 (PST) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org Date: Wed, 18 Jan 2017 00:57:30 +0100 Message-ID: <2377627.GBliyb1Sy7@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1484660264-6531-9-git-send-email-shreyansh.jain@nxp.com> References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484660264-6531-9-git-send-email-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 8/9] eal: enable PCI bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 23:57:32 -0000 2017-01-17 19:07, Shreyansh Jain: > - /* Probe & Initialize PCI devices */ > - if (rte_eal_pci_probe()) > - rte_panic("Cannot probe PCI\n"); > - > /* Probe all the buses and devices/drivers on them */ > if (rte_bus_probe()) > rte_panic("Cannot probe devices\n"); > I like reading this :) It is a good step. A next step could be removing rte_bus_probe() and do it from the scan functions, after letting the application manage the blacklist via a callback.