Re: [dpdk-dev] [PATCH 0/3] Transform the vhost example to two parts: vhost library and example.

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Huawei,

2014-09-02 16:55, Huawei Xie:
> This transform is to facilitate integration with DPDK accelerated ethernet switch.
> 
> Huawei Xie (3):
>   remove vhost example
>   vhost library support to facilitate integration with DPDK accelerated
>     vswitch
>   This vhost example is based on vhost library.     Besides,          -
>     This patch fixes hundreds of 80 character limitation issues.        
>      - Use structure assignment rather than memcpy in get_eth_conf
>     according to         Stephen's comments.

My previous comment was:
"
It would help if you made a first patch to move existing code,
another patch to convert it into a lib, and a last one for
the new example.
So it would show how you transform the old example code and
would be easier to review.
"

I mean your first patch would be some simple code moving without any
change. Git handles move and shows it clearly, so it's really easy to
review.
Then your second patch would include the changes you made to make it
a library. In this patchset we cannot see them because all is seen as
new code.

Thanks
-- 
Thomas