DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Huawei Xie <huawei.xie@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/3] Transform the vhost example to two parts: vhost library and example.
Date: Tue, 02 Sep 2014 11:38:20 +0200
Message-ID: <2377707.iA7Q2h0mzo@xps13> (raw)
In-Reply-To: <1409648131-4301-1-git-send-email-huawei.xie@intel.com>

Hi Huawei,

2014-09-02 16:55, Huawei Xie:
> This transform is to facilitate integration with DPDK accelerated ethernet switch.
> 
> Huawei Xie (3):
>   remove vhost example
>   vhost library support to facilitate integration with DPDK accelerated
>     vswitch
>   This vhost example is based on vhost library.     Besides,          -
>     This patch fixes hundreds of 80 character limitation issues.        
>      - Use structure assignment rather than memcpy in get_eth_conf
>     according to         Stephen's comments.

My previous comment was:
"
It would help if you made a first patch to move existing code,
another patch to convert it into a lib, and a last one for
the new example.
So it would show how you transform the old example code and
would be easier to review.
"

I mean your first patch would be some simple code moving without any
change. Git handles move and shows it clearly, so it's really easy to
review.
Then your second patch would include the changes you made to make it
a library. In this patchset we cannot see them because all is seen as
new code.

Thanks
-- 
Thomas

      parent reply	other threads:[~2014-09-02  9:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02  8:55 Huawei Xie
2014-09-02  8:55 ` [dpdk-dev] [PATCH 1/3] examples/vhost: remove vhost example Huawei Xie
2014-09-02  8:55 ` [dpdk-dev] [PATCH 2/3] lib/librte_vhost: vhost library support to facilitate integration with DPDK accelerated vswitch Huawei Xie
2014-09-03  3:38   ` Tetsuya.Mukawa
2014-09-03  5:39     ` Xie, Huawei
2014-09-03  6:01       ` Stephen Hemminger
2014-09-03  9:43         ` Ananyev, Konstantin
2014-09-03  6:43       ` Tetsuya.Mukawa
2014-09-02  8:55 ` [dpdk-dev] [PATCH 3/3] examples/vhost: vhost example based on vhost library Huawei Xie
2014-09-02  9:38 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2377707.iA7Q2h0mzo@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git