From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id B32E8B388 for ; Tue, 2 Sep 2014 11:33:56 +0200 (CEST) Received: by mail-we0-f182.google.com with SMTP id w62so6619722wes.13 for ; Tue, 02 Sep 2014 02:38:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Yp86Cz2xYGrDv7ZzfjXW2gmaM4b2sNgoK6ZWQQd5LSo=; b=ml/ncstrIyYiCjLVr8PI5xFvIuCejE6Hjw39Gt+4+vOTwl1iddnMRZn+D7IzUFHRmJ 7Uk1ULF4wZUnXd2KssjHQLPctt11xFAKeeQej75tVmYGHVgSfbTiG0GTYL5UM7P3Jbla lFkiRmsOIQlVUKEtk7r9ouPVQsllA92TeMGSwPkNsKCC3SrL+YNI+74BLeuy/MkEKqaE 2mk65ZMmtJpYcE32uPV948o7W87uOKY01+d/mni37UV7kBtlDqkfvUysLayDXak1ZsRZ AM3EYP17021rZUufTU5VCD8lraI8TMJC3EqT+iC3CXpPK/eOaXs814qM21+ZRbGv+uBT EEIA== X-Gm-Message-State: ALoCoQlcYOar1/Xuk4X5Dn9BVtNX3SX2Lf8Rq9B0Uw6NLu42qPWfypZZ3TcVwd0JWkQ5kRl/4U7s X-Received: by 10.194.58.83 with SMTP id o19mr39141879wjq.20.1409650707970; Tue, 02 Sep 2014 02:38:27 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id w10sm33542184wif.15.2014.09.02.02.38.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Sep 2014 02:38:27 -0700 (PDT) From: Thomas Monjalon To: Huawei Xie Date: Tue, 02 Sep 2014 11:38:20 +0200 Message-ID: <2377707.iA7Q2h0mzo@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1409648131-4301-1-git-send-email-huawei.xie@intel.com> References: <1409648131-4301-1-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/3] Transform the vhost example to two parts: vhost library and example. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2014 09:33:56 -0000 Hi Huawei, 2014-09-02 16:55, Huawei Xie: > This transform is to facilitate integration with DPDK accelerated ethernet switch. > > Huawei Xie (3): > remove vhost example > vhost library support to facilitate integration with DPDK accelerated > vswitch > This vhost example is based on vhost library. Besides, - > This patch fixes hundreds of 80 character limitation issues. > - Use structure assignment rather than memcpy in get_eth_conf > according to Stephen's comments. My previous comment was: " It would help if you made a first patch to move existing code, another patch to convert it into a lib, and a last one for the new example. So it would show how you transform the old example code and would be easier to review. " I mean your first patch would be some simple code moving without any change. Git handles move and shows it clearly, so it's really easy to review. Then your second patch would include the changes you made to make it a library. In this patchset we cannot see them because all is seen as new code. Thanks -- Thomas