From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8327AA04F5;
Thu, 12 Dec 2019 23:24:26 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C99C01BF87;
Thu, 12 Dec 2019 23:24:25 +0100 (CET)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id ADE1D1BF84;
Thu, 12 Dec 2019 23:24:24 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 0C93A227AC;
Thu, 12 Dec 2019 17:24:24 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Thu, 12 Dec 2019 17:24:24 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=Ba98dSJUWNTPYO/njk6WTvl9B3a0kP+Z69TDXjBnKTE=; b=HRvGwD/rJ6j+
BvaCauvNNC5tRaQE4cxWi43X1DgfG/i+VZXFk9sHGicL/q+CjprtFb1x6ssw+8TN
/vVh3Uj3mcGsynmWfoXi4XhFOap5gTwb2wej8MnHKf5xtEoxWhQL3tS/t4hWOT7h
Sh05w8CqtovttVFIM1bqNNSjpniC/Xk=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=Ba98dSJUWNTPYO/njk6WTvl9B3a0kP+Z69TDXjBnK
TE=; b=NeP/9YKCrPoeuxv9c+x2qbbRDefla5EyznU9xTZrxSZzcv2noRvu5wXGN
bPcCB1SCutfFLBc3hCh3N7GjZADRNYC9yXmQWo5slGffv9Djk3MchYjA5HH/CMZC
PT3Y3hgPTg26RbVDY2hzdxB9gb/M1N1mZn0TgmG7OkAZMXwhPddQuyM0xoBkGLEb
Ls4+fXqMvzqYkMiYc1mPKk7r9GQx8LvPZ+ELrp4+TTg3JF88Z0t4s469y4OBh6bq
sl7gUSkvYf/bQmhGXVmVVJcxg8OnvMqIU7AWEmQVT9MdcWghDjt2QX5Jn3qp02tp
hi6hrJEK3oJuS/iXdNILIzGtF7jQA==
X-ME-Sender: <xms:F77yXdA3_g-CmGgReMq_yBbTE-xxvttsItgS72QqQaezOteGlhj8HA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeljedgudeiudcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht
hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:F77yXaeoTZ2reTmWiKRxVzli7sjrV4DAplStRHZYfdXsETnpKDvGTg>
<xmx:F77yXUpMNT8r2s8d79t7KmN7SdIEqtAD2FP02_pZrQlDXMUf02UjRQ>
<xmx:F77yXbRnV61TLOPvtUMxfvLxHjXyRX8UXlaFV-1ziFtuE_zERdiixg>
<xmx:GL7yXZiVtcyrtRgxNrLS1GvR81aEOejMNKybimWBHQTrlNgYWV7GRg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id D8F9D8006C;
Thu, 12 Dec 2019 17:24:22 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"stable@dpdk.org" <stable@dpdk.org>, Matan Azrad <matan@mellanox.com>
Date: Thu, 12 Dec 2019 23:24:21 +0100
Message-ID: <2378185.bRGs8SLAUz@xps>
In-Reply-To: <20191211064826.16314-1-alialnu@mellanox.com>
References: <20191211064826.16314-1-alialnu@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] net/mlx: fix variadic macro
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
11/12/2019 07:49, Ali Alnubani:
> This rewrites the MKSTR macro appending an empty string to its arguments
> to resolve build failures similar to:
>
> drivers/net/mlx4/mlx4.c:461:14: fatal error: format string is not a
> string literal [-Wformat-nonliteral]
> MKSTR(path, "%s/device/uevent", device->ibdev_path);
>
> drivers/net/mlx4/mlx4_utils.h:82:30: note: expanded from macro 'MKSTR'
> char name[snprintf(NULL, 0, __VA_ARGS__) + 1]; \
>
> drivers/net/mlx5/mlx5_stats.c:144:15: fatal error: format string is not a
> string literal [-Wformat-nonliteral]
> MKSTR(path, "%s/ports/%d/hw_counters/%s",
>
> drivers/net/mlx5/mlx5_utils.h:149:30: note: expanded from macro 'MKSTR'
> char name[snprintf(NULL, 0, __VA_ARGS__) + 1]; \
>
> The errors reproduce with clang version 9.0.0, and the release notes
> don't mention what could have caused them.
>
> Fixes: 7fae69eeff13 ("mlx4: new poll mode driver")
> Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters")
> Cc: adrien.mazarguil@6wind.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Applied quickly in main tree as it is fixing compilation with a recent clang 9.