From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A6FBA04B7; Wed, 14 Oct 2020 11:29:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80BCF1DB30; Wed, 14 Oct 2020 11:29:52 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 20E901DA95 for ; Wed, 14 Oct 2020 11:29:51 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id BD2655C01C4; Wed, 14 Oct 2020 05:29:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 14 Oct 2020 05:29:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= SP7Fnh5RRtPDhWjjOKdv28M55/tNTb3jzBYwRvpDGYw=; b=vdpoRxtCgCgtPkVr uNklluuGLgmcrIO6XCc2hGTbQIWrEKZkdCiskIzFEE1uPi6eBPwiH/YYA+WhyVoP fNkNr9cyGkFKFIkiMvA1R0dc11fin+CLiAA5WwhA1LGoj7Pui8NO7ooGvBrOdYwS IzG6eI0sNZVH5ShXn6VvlBffOoWO7W9FPlyXucReeUNbCFtw9KxHwnvLOv6Vd0hp hFiApXRyRvVKS9Yb+8fgEGp1fadLVcrcd9wmOufOzIYeW58e1/0jluSWLxgY1HzZ K/Q75Xyr9pd9CnWnkRDw9FNMGGBxILMYfIRtxpryjqSbS4pBvEs7aj+YXmw0lBx0 s+2ZOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=SP7Fnh5RRtPDhWjjOKdv28M55/tNTb3jzBYwRvpDG Yw=; b=QycFuOMj+er6BzWSNiOZiQ/D3HsXpM4HVXOD2EFbFEBIOXr0soMoE7C6W hG7UBUuyo/JV0X1aBjDfl4ncjR7rnrnTaGj+3pRixWNnBtc74cD9Uo/CHPfnasRe rTeCptsXjxFp9XdFUquCNWQQw4CvWPmWvtVIxG/IIHqQV86EDmePgRhWUAMjYYps vbfhCvXV+K2hvi+41mAKsgUFrDyyBoQIuHQxt7GqI0Mhnmg5veA6F5Il0cZcDxry CKKWyedkimoaSeTtfSw+RHHat+ZBdkG/2alHlKQcbaijIFRB3PkAjYGu8LF/9FgF 3pZDuPRJq+RdE5DjnzSxltsIa8DhQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedriedugdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 616C43280064; Wed, 14 Oct 2020 05:29:46 -0400 (EDT) From: Thomas Monjalon To: Narcisa Ana Maria Vasile Cc: dev@dpdk.org, ocardona@microsoft.com, haramakr@linux.microsoft.com, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, dmitrym@microsoft.com, Harini Ramakrishnan , Ranjit Menon , Narcisa Vasile Date: Wed, 14 Oct 2020 11:29:45 +0200 Message-ID: <2382564.98p6WmCBFr@thomas> In-Reply-To: <7f5f4978-f967-66e8-5152-5446198bfd42@intel.com> References: <1600483953-28579-1-git-send-email-navasile@linux.microsoft.com> <1601592908-11262-1-git-send-email-navasile@linux.microsoft.com> <7f5f4978-f967-66e8-5152-5446198bfd42@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] windows/netuio: add Windows NetUIO kernel driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/10/2020 20:21, Ranjit Menon: > On 10/1/2020 3:55 PM, Narcisa Ana Maria Vasile wrote: > > From: Narcisa Vasile > > > > The Windows netuio kernel driver provides the DPDK userspace application > > with direct access to hardware, by mapping the HW registers in userspace > > and allowing read/write operations from/to the device > > configuration space. > > > > Two IOCTLs are defined by the netuio interface: > > * IOCTL_NETUIO_MAP_HW_INTO_USERSPACE > > - used for mapping the device registers into userspace > > * IOCTL_NETUIO_PCI_CONFIG_IO > > - used to read/write from/into the device configuration space > > > > Note: > > Requests to map the device BARs into userspace need to be processed > > in the thread context of the process that initiated the mapping request. > > Otherwise, the BARs might end up mapped into an arbitrary process > > address space. > > EvtIoInCallerContext is used to ensure the requests are handled > > in the right user thread context. Other requests (PCI config) > > are sent back to the framework and processed by the EvtIoDeviceControl > > callback. > > > > Cc: Harini Ramakrishnan > > Cc: Omar Cardona > > Cc: Dmitry Malloy > > Signed-off-by: Narcisa Vasile > > We'll need to do a code-style cleanup at some point, but for now: > > Reviewed-by: Ranjit Menon > Acked-by: Ranjit Menon For info, Reviewed-by is stronger because it means you carefully checked the code. I drop Acked-by redundancy in this case. With Reviewed-by: Dmitry Kozlyuk Applied, thanks For next patches, I would prefer a prefix "kmods" in the subject: --subject-prefix='kmods PATCH'