DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test: fix to skip kni autotest
@ 2018-11-13 14:00 Pallantla Poornima
  2018-11-13 16:08 ` Pattan, Reshma
  0 siblings, 1 reply; 3+ messages in thread
From: Pallantla Poornima @ 2018-11-13 14:00 UTC (permalink / raw)
  To: dev; +Cc: reshma.pattan, ferruh.yigit, Pallantla Poornima, stable

Kni_autotest should be skipped if rte_kni.ko module is not loaded.
Hence changed return as TEST_SKIPPED.

Fixes: ee1caebc4d ("test/kni: check module dependency")
Cc: stable@dpdk.org

Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
---
 test/test/test_kni.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test/test_kni.c b/test/test/test_kni.c
index f3c19b5a0..c92c09054 100644
--- a/test/test/test_kni.c
+++ b/test/test/test_kni.c
@@ -549,7 +549,7 @@ test_kni(void)
 	if (!dir) {
 		if (errno == ENOENT) {
 			printf("Cannot run UT due to missing rte_kni module\n");
-			return -1;
+			return TEST_SKIPPED;
 		}
 		printf("opendir: %s", strerror(errno));
 		return -1;
-- 
2.13.6

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test: fix to skip kni autotest
  2018-11-13 14:00 [dpdk-dev] [PATCH] test: fix to skip kni autotest Pallantla Poornima
@ 2018-11-13 16:08 ` Pattan, Reshma
  2018-11-14  3:52   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Pattan, Reshma @ 2018-11-13 16:08 UTC (permalink / raw)
  To: Poornima, PallantlaX, dev; +Cc: Yigit, Ferruh, stable



> -----Original Message-----
> From: Poornima, PallantlaX
> Sent: Tuesday, November 13, 2018 2:00 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Poornima, PallantlaX
> <pallantlax.poornima@intel.com>; stable@dpdk.org
> Subject: [PATCH] test: fix to skip kni autotest
> 
> Kni_autotest should be skipped if rte_kni.ko module is not loaded.
> Hence changed return as TEST_SKIPPED.
> 
> Fixes: ee1caebc4d ("test/kni: check module dependency")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>

Acked-by: Reshma Pattan <reshma.pattan@intel.cm>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test: fix to skip kni autotest
  2018-11-13 16:08 ` Pattan, Reshma
@ 2018-11-14  3:52   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-11-14  3:52 UTC (permalink / raw)
  To: Poornima, PallantlaX; +Cc: dev, Pattan, Reshma, Yigit, Ferruh, stable

13/11/2018 17:08, Pattan, Reshma:
> From: Poornima, PallantlaX
> > 
> > Kni_autotest should be skipped if rte_kni.ko module is not loaded.
> > Hence changed return as TEST_SKIPPED.
> > 
> > Fixes: ee1caebc4d ("test/kni: check module dependency")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> 
> Acked-by: Reshma Pattan <reshma.pattan@intel.cm>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-14  3:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-13 14:00 [dpdk-dev] [PATCH] test: fix to skip kni autotest Pallantla Poornima
2018-11-13 16:08 ` Pattan, Reshma
2018-11-14  3:52   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git