From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 8F80634F0 for ; Mon, 26 Mar 2018 14:30:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1361320A90; Mon, 26 Mar 2018 08:30:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 26 Mar 2018 08:30:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Eci1uMq86yhQM32AjOa5oR7rwr 5xhs8VOE3BTn3UE1M=; b=Od5vgjsvrWvkbqtggXn6k45qg0dUCOb2jMlCQxqP8B yuer1ipGyXiZ+5JbNDFONpjM4t2ZUKtplN7gEHJhp30SCaxJVul+YrxfJ9dWXXh6 kR8AWwjoPKU+NfZRAE0HXePN7BgqKGWeW4QB/eJXsaV1qKt+0OF+Kw07k3lCGa/R k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Eci1uM q86yhQM32AjOa5oR7rwr5xhs8VOE3BTn3UE1M=; b=PjZln2nmGo4u2KkLPT+snT wNv9QtU81j32YI2Qepn1U2zK7yBg80stwVU6rQqr3Ri1e32mIvbUngsTfI+CeJz1 91BubKnbo8h8GW/ZznwCjQzS4HphCEvXbgxaRxgFYRvXuSs7CFaqTb0YGBmpAmLA BF/voaYSjBhLzvG4oY19aPnlg3phgiqeXAh5RzV+ob71yli9f4kpSSpzpxLctXPM Hj+AFP+g/RivOY5NaWtcAIBTePDbuTKoWWRz/i9M/Hxi+6hqTBj2gHYYsoEaRgq+ RUD6NAgvBgawuHgitCNB8hE1BEQG9cJdbwxoLU/RKIBIVLWakFmSjzph17uCY0Rg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30741E4472; Mon, 26 Mar 2018 08:30:35 -0400 (EDT) From: Thomas Monjalon To: Adrien Mazarguil Cc: Ferruh Yigit , Ophir Munk , dev@dpdk.org, Olga Shern , Shahaf shuler Date: Mon, 26 Mar 2018 14:30:34 +0200 Message-ID: <2388926.RzC4zprzFL@xps> In-Reply-To: <20180326115452.GF4011@6wind.com> References: <1521477410-8936-1-git-send-email-ophirmu@mellanox.com> <20180326115452.GF4011@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 12:30:36 -0000 26/03/2018 13:54, Adrien Mazarguil: > On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > > Previous to this commit mlx4 CRC stripping was executed by default and > > > there was no verbs API to disable it. > > > > Are you aware of the discussion about CRC [1]? Is this patch compatible with plans? > > > > [1] > > https://dpdk.org/dev/patchwork/patch/36415/ > > I wasn't aware of this notice. Looks like it makes this patch unnecessary > since mlx4 always strip by default; this patch makes it configurable at will > and only exposes the capability when HW supports its configuration (i.e. the > ability to leave CRC inside mbuf). > > We'd just need mlx4 to not expose DEV_RX_OFFLOAD_CRC_STRIP at all in > mlx5_get_rx_queue_offloads() in order to fully comply. > > I leave it up to you, I don't mind if we include this patch only to revert > it later when we finally get rid of DEV_RX_OFFLOAD_CRC_STRIP. A new flag to keep CRC will be introduced. We will need toggling anyway.